Make external account identifier APIs return multiple identifiers
ClosedPublic
Actions

Authored by epriestley on Feb 21 2020, 3:23 PM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rPe43ecad8afc4: Make external account identifier APIs return multiple identifiers

Summary

Depends on D21012. Ref T13493. Currently, auth adapters return a single identifier for each external account.

Allow them to return more than one identifier, to better handle cases where an API changes from providing a lower-quality identifier to a higher-quality identifier.

On its own, this change doesn't change any user-facing behavior.

Test Plan

Linked and unlinked external accounts.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 21 2020, 3:23 PM

Harbormaster completed remote builds in B23881: Diff 50057.Feb 21 2020, 3:24 PM

epriestley requested review of this revision.Feb 21 2020, 3:24 PM

epriestley added a child revision: D21014: Update unusual handling of external accounts in "Password" auth provider.Feb 21 2020, 3:54 PM

Fix a logic bug in the OAuth2 provider.

Harbormaster completed remote builds in B23886: Diff 50062.Feb 22 2020, 4:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:45 AM

Closed by commit rPe43ecad8afc4: Make external account identifier APIs return multiple identifiers (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe43ecad8afc4: Make external account identifier APIs return multiple identifiers.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/auth/adapter/PhutilAuthAdapter.php (5 lines)
M			src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php (9 lines)
M			src/applications/auth/provider/PhabricatorAuthProvider.php (57 lines)
M			src/applications/auth/provider/PhabricatorLDAPAuthProvider.php (4 lines)
M			src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php (6 lines)
M			src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50057	6ad5008		Feb 21 2020, 3:22 PM	★	★
Diff 2	50062	6ad5008	- Fix a logic bug in the OAuth2 provider.	Feb 22 2020, 4:45 PM	★	★
Diff 3	50076	4094624	rPe43ecad8afc4590156305e683ca8acc96f1edcfd	Feb 23 2020, 1:45 AM	★	★

Status	Author	Revision
Closed	epriestley	D21023 Read both older "key" and newer "accountId" identifiers from JIRA during authentication
Closed	epriestley	D21022 Remove all readers and writers of "accountID" on "ExternalAccount"
Closed	epriestley	D21019 Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount"
Closed	epriestley	D21018 Update Asana feed publishing integration for "ExternalAccountIdentifier"
Closed	epriestley	D21017 Migrate all "accountID" values to "ExternalAccountIdentifier" objects
Closed	epriestley	D21016 Write ExternalAccountIdentifiers when interacting with external authentication providers
Closed	epriestley	D21015 Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
Closed	epriestley	D21014 Update unusual handling of external accounts in "Password" auth provider
Closed	epriestley	D21013 Make external account identifier APIs return multiple identifiers
Closed	epriestley	D21012 Remove an ancient no-op check for duplicated external accounts