Page MenuHomePhabricator
Differential D21023

Read both older "key" and newer "accountId" identifiers from JIRA during authentication
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 1:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 5:13 PM
Unknown Object (File)
Thu, Jan 30, 2:36 PM
Unknown Object (File)
Thu, Jan 30, 2:36 PM
Unknown Object (File)
Thu, Jan 30, 2:36 PM
Unknown Object (File)
Tue, Jan 28, 5:30 AM
Unknown Object (File)
Sat, Jan 25, 6:43 AM
Unknown Object (File)
Sat, Jan 25, 6:43 AM
Unknown Object (File)
Sat, Jan 25, 6:43 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rPe58ef418c798: Read both older "key" and newer "accountId" identifiers from JIRA during…
Summary

Depends on D21022. Ref T13493. The JIRA API has changed from using "key" to identify users to using "accountId".

By reading both identifiers, this linkage "just works" if you run against an old version of JIRA, a new version of JIRA, or an intermediate version of JIRA.

It also "just works" if you run old JIRA, upgrade to intermediate JIRA, everyone refreshes their link at least once, then you upgrade to new JIRA.

This is a subset of cases and does not include "sudden upgrade to new JIRA", but it's strictly better than the old behavior for all cases it covers.

Test Plan

Linked, unlinked, and logged in with JIRA. Looked at the "ExternalAccountIdentifier" table and saw a sensible value.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
25 lines

Diff 50084

View Options

src/applications/auth/adapter/PhutilJIRAAuthAdapter.php

Loading...
Phabricator · Built by Phacility