Page MenuHomePhabricator

Make the "result" property on Future private
ClosedPublic

Authored by epriestley on Feb 26 2020, 8:29 PM.

Details

Summary

Depends on D21033. Ref T11968. This is just an incremental step in modernizing Future and making it more robust. Currently, subclasses are expected to write directly to $this->result, but this isn't consistent with how modern classes generally work.

Test Plan

Ran unit tests, created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 26 2020, 8:29 PM
epriestley requested review of this revision.Feb 26 2020, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sun, Mar 29, 5:18 PM
This revision was automatically updated to reflect the committed changes.
artms added a subscriber: artms.Thu, Apr 2, 2:54 PM
artms added inline comments.
src/future/Future.php
103
103
PHP Fatal error:  Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-75/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50