Page MenuHomePhabricator
Differential D21038

Integrate "ServiceProfiler" into the base "Future"
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:53 PM.
Tags
None
Referenced Files
F18375785: D21038.diff
Thu, Aug 28, 10:21 AM
F18122844: D21038.id50110.diff
Wed, Aug 13, 12:06 PM
F18112890: D21038.id.diff
Tue, Aug 12, 9:47 PM
F18110238: D21038.diff
Mon, Aug 11, 5:37 PM
F18100921: D21038.diff
Sat, Aug 9, 12:10 PM
F17661915: D21038.id50143.diff
Jul 12 2025, 4:44 PM
F17639952: D21038.diff
Jul 11 2025, 6:05 PM
Unknown Object (File)
Jun 5 2025, 2:40 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
T13177: ServiceProfiler integration should be a configurable part of Future, not hard-coded into subclasses (HTTPSFuture, ExecFuture)
Commits
rARCb1a712add815: Integrate "ServiceProfiler" into the base "Future"
Summary

Depends on D21036. Ref T11968. Ref T13177. Currently, each Future integrates separately with ServiceProfiler, but much of the code is similar.

Move integration to the base class and lift up most of the implementation details.

Test Plan

Ran arc diff --trace, saw sensible output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
future/
43 lines
8 lines
exec/
55 lines
36 lines
http/
17 lines
20 lines

Diff 50143

View Options

src/future/Future.php

Loading...
View Options

src/future/FutureProxy.php

Loading...
View Options

src/future/exec/ExecFuture.php

Loading...
View Options

src/future/exec/PhutilExecPassthru.php

Loading...
View Options

src/future/http/HTTPFuture.php

Loading...
View Options

src/future/http/HTTPSFuture.php

Loading...
Phabricator · Built by Phacility