Differential D21033

Resolve all futures inside FutureIterator
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 7:34 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARCe20dce875cf2: Resolve all futures inside FutureIterator

Summary

Depends on D21032. Ref T11968. Currently, "Future" and "FutureIterator" can both resolve futures.

Treat "Future->resolve()" as sugar on resolving an iterator of size 1.

Test Plan

Ran tests, created this revision.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 26 2020, 7:34 PM

Harbormaster completed remote builds in B23923: Diff 50102.Feb 26 2020, 7:35 PM

epriestley requested review of this revision.Feb 26 2020, 7:35 PM

Also remove uncalled "checkException()" method.

Harbormaster completed remote builds in B23924: Diff 50103.Feb 26 2020, 7:41 PM

epriestley added a child revision: D21034: Make the "result" property on Future private.Feb 26 2020, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2020, 5:18 PM

Closed by commit rARCe20dce875cf2: Resolve all futures inside FutureIterator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe20dce875cf2: Resolve all futures inside FutureIterator.

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

82 lines

FutureIterator.php

60 lines

Diff 50139

View Options

src/future/Future.php