Page MenuHomePhabricator

Read both email addresses and Google Account IDs from Google OAuth
ClosedPublic

Authored by epriestley on Feb 24 2020, 9:23 PM.

Details

Summary

Ref T13493. Google returns a lower-quality account identifier ("email") and a higher-quality account identifier ("id"). We currently read only "email".

Change the logic to read both "email" and "id", so that if Google ever moves away from "email" the transition will be a bit easier.

Test Plan

Linked/unlinked a Google account, looked at the external account identifier table.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 24 2020, 9:23 PM
epriestley requested review of this revision.Feb 24 2020, 9:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 9:26 PM
This revision was automatically updated to reflect the committed changes.