HomePhabricator
Diffusion Phabricator d3f4af4a3a0b

Add more layout constraints to tokenizer CSS to prevent layout issues with…
d3f4af4a3a0b
Actions

Description

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73

Summary:
Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan:
Before:

Screen Shot 2020-02-24 at 7.27.06 AM.png (83×723 px, 17 KB)

After:

Screen Shot 2020-02-24 at 7.44.47 AM.png (69×264 px, 10 KB)

Maniphest Tasks: T13495

Differential Revision: https://secure.phabricator.com/D21026

Details

Provenance
epriestleyAuthored on Feb 24 2020, 3:43 PM
epriestleyPushed on Feb 24 2020, 4:00 PM
Differential Revision
D21026: Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73
Parents
rPe58ef418c798: Read both older "key" and newer "accountId" identifiers from JIRA during…
Branches
Unknown
Tags
Unknown
Tasks
T13495: In Firefox 73 and some other browser at non-100% zoom levels, Chinese glyphs cause tokenizer tokens to take up too much vertical space
Build Status
Buildable 23912
Build 32903: Run Core Tests

Changes (1)

PathSize
webroot/
rsrc/
css/
aphront/

rPd3f4af4a3a0b

View Options

webroot/rsrc/css/aphront/tokenizer.css

Loading...
Phabricator · Built by Phacility