Paths

Table of Contentst

Differential D21019

Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount"
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 10:29 PM.

Tags

None

Referenced Files

	F13527350: D21019.id50065.diff
	Fri, Jul 26, 4:59 PM

	Unknown Object (File)
	Mon, Jul 22, 2:09 PM

	Unknown Object (File)
	Sat, Jul 20, 5:55 AM

	Unknown Object (File)
	Sat, Jul 20, 4:31 AM

	Unknown Object (File)
	Sat, Jul 20, 1:17 AM

	Unknown Object (File)
	Sun, Jul 14, 5:36 PM

	Unknown Object (File)
	Sat, Jul 13, 2:27 AM

	Unknown Object (File)
	Thu, Jul 11, 5:32 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T6703: Allow multiple copies of the same auth provider type
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP84b5ad09e6e2: Remove all readers and all nontrivial writers for "accountType" and…

Summary

Depends on D21018. Ref T13493. Ref T6703. The "ExternalAccount" table has a unique key on <accountType, accountDomain, accountID> but this no longer matches our model of reality and changes in this sequence end writes to accountID.

Remove this key.

Then, remove all readers of accountType and accountDomain (and all nontrivial writers) because none of these callsites are well-aligned with plans in T6703.

This change has no user-facing impact today: all the rules about linking/unlinking/etc remain unchanged, because other rules currently prevent creation of more than one provider with a given "accountType".

Test Plan

Linked an OAuth1 account (JIRA).
Linked an OAuth2 account (Asana).
Used bin/auth refresh to cycle OAuth tokens.
Grepped for affected symbols.
Published an Asana update.
Published a JIRA link.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 22 2020, 10:29 PM

Owners added a subscriber: Restricted Owners Package.Feb 22 2020, 10:29 PM

Harbormaster completed remote builds in B23889: Diff 50065.Feb 22 2020, 10:31 PM

epriestley requested review of this revision.Feb 22 2020, 10:31 PM

epriestley added a child revision: D21022: Remove all readers and writers of "accountID" on "ExternalAccount".Feb 23 2020, 1:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:48 AM

Closed by commit rP84b5ad09e6e2: Remove all readers and all nontrivial writers for "accountType" and… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP84b5ad09e6e2: Remove all readers and all nontrivial writers for "accountType" and….

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20200222.xident.02.dropkey.php

21 lines

src/

applications/

auth/

controller/

PhabricatorAuthLoginController.php

17 lines

management/

PhabricatorAuthManagementRefreshWorkflow.php

34 lines

provider/

PhabricatorAuthProvider.php

17 lines

PhabricatorOAuth2AuthProvider.php

2 lines

query/

PhabricatorExternalAccountQuery.php

26 lines

doorkeeper/

bridge/

DoorkeeperBridgeAsana.php

6 lines

DoorkeeperBridgeJIRA.php

5 lines

option/

PhabricatorAsanaConfigOptions.php

6 lines

worker/

DoorkeeperAsanaFeedWorker.php

46 lines

DoorkeeperJIRAFeedWorker.php

7 lines

people/

storage/

PhabricatorExternalAccount.php

38 lines

Diff 50082

resources/sql/autopatches/20200222.xident.02.dropkey.php

Loading...

src/applications/auth/controller/PhabricatorAuthLoginController.php

Loading...

src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php

Loading...

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...

src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php

Loading...

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Loading...

src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php

Loading...

src/applications/doorkeeper/bridge/DoorkeeperBridgeJIRA.php

Loading...

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

Loading...

src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php

Loading...

src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php

Loading...

src/applications/people/storage/PhabricatorExternalAccount.php

Loading...