Page MenuHomePhabricator
Create Task
Maniphest T13463

When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx"
Closed, ResolvedPublic
Actions

Description

See PHI1555.

Revisions may be related to tasks with a DifferentialRevisionHasTaskEdgeType::EDGECONST edge, either via Edit Related Objects... → Edit Tasks in the web UI or by running arc diff on a branch named Txxx.... However, this relationship is not transferred to commits, so commits don't end up attached to tasks and don't show up in the (recently updated) "Related Changes" table.

For now, I plan to treat these relationships like we treat Ref Txxx in the commit message, and effectively copy the edge when we discover a commit. Copying edges isn't great, but "Ref" and "Fixes" sort of work like this already, and even if this is walked back later it isn't a big deal.

See also T3577 (which has some adjacent discussion) and T11934.

Revisions and Commits

rP Phabricator
D20961rP4904d7711ea1 When publishing a commit, copy "Related Tasks" from the associated revision (if…

Related Objects
Search...

Event Timeline

epriestley triaged this task as Low priority.Nov 21 2019, 4:02 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptNov 21 2019, 4:02 PM
epriestley updated the task description. (Show Details)Nov 21 2019, 4:02 PM
epriestley added a parent task: T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
epriestley added a subtask: T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
epriestley mentioned this in T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".Nov 21 2019, 4:04 PM
epriestley merged a task: T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
epriestley added subscribers: hach-que, chad, Luke081515.2 and 2 others.
swisspol added a subscriber: swisspol.Nov 29 2019, 7:24 AM
epriestley added a revision: D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists).Jan 30 2020, 6:32 PM
swisspol added a comment.Feb 3 2020, 6:46 PM

@epriestley what's blocking landing this diff?

epriestley added a comment.Feb 3 2020, 7:02 PM

I just wanted to hold it across the release cut, it's headed to master shortly.

epriestley closed this task as Resolved by committing rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if….Feb 4 2020, 3:05 PM
epriestley added a commit: rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if….
epriestley added a comment.Feb 24 2020, 9:00 PM

One minor issue with this is that there's some duplication when the commit Fixes Txxx and the associated revision already has the edge (which is very common if the commit Fixes Txxx, because the revision almost always also Fixes Txxx):

Screen Shot 2020-02-24 at 12.57.25 PM.png (103×1 px, 32 KB)

This could probably be fixed by making "alice closed X as Y by committing Z" also write the relationship edge.

Phabricator · Built by Phacility