Page MenuHomePhabricator
Differential D21024

Fix two "implode()" order issues arising from wilds/experimental collapse
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 4:33 PM.
Tags
None
Referenced Files
F18828194: D21024.id.diff
Fri, Oct 24, 2:58 PM
F18820433: D21024.diff
Wed, Oct 22, 3:04 PM
F18800213: D21024.id50086.diff
Fri, Oct 17, 3:53 PM
F18765920: D21024.diff
Oct 7 2025, 1:49 PM
F18734164: D21024.id.diff
Sep 30 2025, 10:49 PM
F18630805: D21024.id50086.diff
Sep 16 2025, 12:59 PM
F18615631: D21024.id.diff
Sep 14 2025, 3:06 PM
F18604278: D21024.diff
Sep 13 2025, 6:24 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse
Summary

Ref T13490. There's one simple "implode()" order issue here, and one slightly more complex one that uses "DIRECTORY_SEPARATOR" as glue.

Add test coverage for this, update the lint check to detect constants used as glue, and fix the callsites.

Test Plan
  • Added a failing test and made it pass.
  • Ran arc lint --everything and looked for remaining implode warnings, found none.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2020, 4:33 PM
Harbormaster completed remote builds in B23907: Diff 50085.Feb 23 2020, 4:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 4:33 PM
epriestley requested review of this revision.
Closed by commit rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse.

Revision Contents
Changeset List

PathSize
src/
filesystem/
2 lines
lint/
linter/
xhpast/
rules/
12 lines
__tests__/
implode-argument-order/
5 lines
workflow/
2 lines

Diff 50086

View Options

src/filesystem/Filesystem.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistImplodeArgumentOrderXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/implode-argument-order/implode.lint-test

Loading...
View Options

src/workflow/ArcanistCloseWorkflow.php

Loading...
Phabricator · Built by Phacility