Page MenuHomePhabricator

Fix two "implode()" order issues arising from wilds/experimental collapse
ClosedPublic

Authored by epriestley on Feb 23 2020, 4:33 PM.

Details

Summary

Ref T13490. There's one simple "implode()" order issue here, and one slightly more complex one that uses "DIRECTORY_SEPARATOR" as glue.

Add test coverage for this, update the lint check to detect constants used as glue, and fix the callsites.

Test Plan
  • Added a failing test and made it pass.
  • Ran arc lint --everything and looked for remaining implode warnings, found none.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 4:33 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.