HomePhabricator

Update Phage for toolsets and restore library loading behaviors

Authored by epriestley on Feb 23 2020, 4:40 PM.

Description

Update Phage for toolsets and restore library loading behaviors

Summary: Ref T13490. This makes the "phage" toolset work properly and updates external library behavior to match the "classic" behavior, except that "--library" is now supported.

Test Plan: Ran "phage remote" workflows.

Maniphest Tasks: T13490

Differential Revision: https://secure.phabricator.com/D21025

Event Timeline

solarnz added inline comments.
/src/runtime/ArcanistRuntime.php
411–421

This results in arcanist trying to load the libraries from within the arcanist directory, as we don't get the parent directory.

Changing the code to something similar to

if (!$resolved) {
  $arcanist_root = phutil_get_library_root('arcanist');
  $arcanist_root = dirname($arcanist_root) . '/../';

Resolves this