Update Phage for toolsets and restore library loading behaviors
9cd72baae92c
Actions

Description

Update Phage for toolsets and restore library loading behaviors

Summary: Ref T13490. This makes the "phage" toolset work properly and updates external library behavior to match the "classic" behavior, except that "--library" is now supported.

Test Plan: Ran "phage remote" workflows.

Maniphest Tasks: T13490

Differential Revision: https://secure.phabricator.com/D21025

Details

Provenance

epriestley	Authored on Feb 23 2020, 4:40 PM
epriestley	Pushed on Feb 23 2020, 5:30 PM

Differential Revision

D21025: Update Phage for toolsets and restore library loading behaviors

Parents

rARCde461bb1794f: Fix two "implode()" order issues arising from wilds/experimental collapse

Branches

Unknown

Tags

Unknown

Tasks

T13490: Upgrade all "classic" Arcanist workflows to Toolsets

Build Status

Buildable 23910
Build 32900: Run Core Tests

Event Timeline

epriestley committed rARC9cd72baae92c: Update Phage for toolsets and restore library loading behaviors (authored by epriestley).Feb 23 2020, 5:30 PM

epriestley added a task: T13490: Upgrade all "classic" Arcanist workflows to Toolsets.

epriestley added an edge: D21025: Update Phage for toolsets and restore library loading behaviors.

Harbormaster completed building B23910: rARC9cd72baae92c: Update Phage for toolsets and restore library loading behaviors.Feb 23 2020, 5:31 PM

solarnz added a subscriber: solarnz.Feb 23 2020, 10:52 PM

solarnz added inline comments.

/src/runtime/ArcanistRuntime.php
411–421	This results in arcanist trying to load the libraries from within the arcanist directory, as we don't get the parent directory. Changing the code to something similar to if (!$resolved) { $arcanist_root = phutil_get_library_root('arcanist'); $arcanist_root = dirname($arcanist_root) . '/../'; Resolves this