Differential D21035

Make "exception" on Future a private property
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 12:16 AM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARC6b75562c3e9b: Make "exception" on Future a private property

Summary

Depends on D21034. Ref T11968. Continue modernizing Future.

Test Plan

Ran tests, created a revision.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 27 2020, 12:16 AM

Harbormaster completed remote builds in B23926: Diff 50105.Feb 27 2020, 12:17 AM

epriestley requested review of this revision.Feb 27 2020, 12:17 AM

epriestley added a child revision: D21036: Make "FutureIterator" queue management more formal.Feb 27 2020, 2:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Mar 30, 2:34 PM

Closed by commit rARC6b75562c3e9b: Make "exception" on Future a private property (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC6b75562c3e9b: Make "exception" on Future a private property.

Revision Contents
Changeset List

			Path	Packages
M			src/future/Future.php (51 lines)
M			src/future/FutureIterator.php (67 lines)
M			src/future/FutureProxy.php (30 lines)

Diff 50141

src/future/Future.php

Loading...

src/future/FutureIterator.php

Loading...

src/future/FutureProxy.php

Loading...