Page MenuHomePhabricator

When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic

Authored by epriestley on Feb 27 2020, 2:16 PM.
Tags
None
Referenced Files
F15378323: D21037.id50107.diff
Thu, Mar 13, 1:51 PM
F15342519: D21037.id50107.diff
Sun, Mar 9, 9:10 PM
F15336155: D21037.diff
Sat, Mar 8, 6:18 PM
F15284316: D21037.diff
Tue, Mar 4, 9:33 AM
Unknown Object (File)
Mon, Mar 3, 2:26 PM
Unknown Object (File)
Sat, Mar 1, 5:05 PM
Unknown Object (File)
Sat, Feb 22, 3:38 PM
Unknown Object (File)
Feb 3 2025, 11:38 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/failed-arc-patch-does-not-return-non-zero-exit-code/3584.

Returning an integer from a top-level PHP file doesn't actually affect the process exit code, as much as I might wish it does.

Test Plan

Ran arc patch adflsnadfsln; echo $?, saw a nonzero exit code after this fix.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2020, 2:17 PM
Harbormaster failed remote builds in B23928: Diff 50107!
This revision was not accepted when it landed; it landed in state Changes Planned.Feb 27 2020, 2:17 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.