When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:16 PM.

Details

Reviewers: None
Commits: rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code

Summary

See https://discourse.phabricator-community.org/t/failed-arc-patch-does-not-return-non-zero-exit-code/3584.

Returning an integer from a top-level PHP file doesn't actually affect the process exit code, as much as I might wish it does.

Test Plan

Ran arc patch adflsnadfsln; echo $?, saw a nonzero exit code after this fix.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 27 2020, 2:16 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 27 2020, 2:17 PM

Harbormaster failed remote builds in B23928: Diff 50107!

This revision was not accepted when it landed; it landed in state Changes Planned.Feb 27 2020, 2:17 PM

This revision was landed with ongoing or failed builds.

Closed by commit rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC5451d2875221: When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code.

Revision Contents
Changeset List

Path

Size

bin/

arc

2 lines

phage

2 lines

support/

init/

init-arcanist.php

4 lines

Diff 50108

View Options

bin/arc

View Options

bin/phage

View Options

support/init/init-arcanist.php

When "ArcanistRuntime" exits with a nonzero exit code, emit that exit codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50108

bin/arc

bin/phage

support/init/init-arcanist.php

When "ArcanistRuntime" exits with a nonzero exit code, emit that exit code
ClosedPublic
Actions

Revision Contents
Changeset List