Page MenuHomePhabricator

Remove an ancient no-op check for duplicated external accounts

Authored by epriestley on Feb 21 2020, 12:11 AM.



Ref T13493. This check was introduced in D4647, but the condition can never be reached in modern Phabricator because the table has a unique key on <accountType, accountDomain, accountID> -- so no row can ever exist with the same value for that tuple but a different ID.

(I'm not entirely sure if it was reachable in D4647 either.)

Test Plan

Used SHOW CREATE TABLE to look at keys on the table and reasoned that this block can never have any effect.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.