The fix for T13031 may have made this worse by default, since we now extract all pushed changesets and hold them in memory by default, even if no Herald content-based rules which use them actually exist. This may create too much memory pressure if you push a very large number of commits.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 25 2018
Jan 18 2018
Jan 9 2018
Jan 4 2018
Dec 26 2017
Dec 22 2017
Dec 18 2017
Adjacently, some other parts of the UI currently use the word "enormous" (see https://discourse.phabricator-community.org/t/herald-enormous-check/822). They should be rewritten to use different language (like "Very Large"). We should use the term "Enormous" to mean only "too large to process completely", while the other UI uses it to mean "large enough to partially collapse for viewer convenience".
Also, while it's on my mind, all repositories should probably have this rule today:
See PHI242. SR Latch:
Dec 5 2017
Dec 1 2017
Nov 23 2017
I'm unable to close this, but I believe this to be resolved (or at least my specific repro of flags via herald no longer applies I believe).
Oct 31 2017
Ah, thanks. I think your guess is right. I'll make a note in T2543, should be a one-line fix I think.
From https://discourse.phabricator-community.org/t/644 - it appears that HM now triggers a build on revisions when they are closed via landing, which fails because the build expects a Staging ref. I don't have the setup to test any of it, but the latest revision landed here doesn't show the behavior, so either f7f3dd5b2084 hasn't rolled in here yet, or that user is doing something funny.
Oct 27 2017
oh, nice work, it will trigger parent task as well when subtask changed, seems I need to add the "condition" like subtask status instead of a "action" for this... any samples? Thanks!
Oct 26 2017
Question: When subtask was fixed, the parent task want to have a action, for example, add a tag or change status if all subtasks were fixed.
So how to get this work in the extention of herald action? Thanks in advance!~
Oct 24 2017
Oct 4 2017
The best place for this kind of question is now your organization's support pact -- @tammybutow or @alexmv should be able to help you get access.
@epriestley so maybe this isn't the right place to leave this comment (let me know if I should create a new task?) but I'm finding this is acting in a way that seems a bit inconsistent. In particular, I added a new boolean custom field --
Aug 25 2017
Herald rules are now always public, which possibly addresses the original issue.
Aug 21 2017
Aug 6 2017
oh thanks!
I don't think this is resolved, just an unclear report. To access this screen:
Jul 9 2017
Jul 8 2017
Methinks that the Rube Goldberg solution for this would be to get unittest.skip to have another argument with a task number, and then validate with lint/runtime that it look like T1234. And then maybe grep the body of the ticket for the filename.
Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?
That is, I think the right tool for the job is either runtime enforcement or lint enforcement: make unittest.skip() with no reason fail (so the tests don't pass) or make lint raise a warning like "unittest.skip() must have a comment above it explaining the plan for re-enabling the test.".
Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?
I know about T9853, but if there's still a chance you might consider merging that upstream, there are a few folks here at Khan Academy who are excited by the feature. Here's one example:
Jun 20 2017
Yeah, I'm pretty pessimistic about the security of SMS (or voice) as a factor. See also T7639 and T6549#97130. The article identifies these vectors:
Jun 13 2017
Thanks :)
Jun 12 2017
Jun 10 2017
May 31 2017
From T12771:
Global Rule for Differential Diffs
When:
[ Repository ] [ does not exist ]
Take these actions:
[ Block diff with message ] [ "Repository unrecognized. See https://helpful-docs.com/repository-help for details." ]
May 18 2017
We have lots of APIs for external things, but without knowing what you're trying to do specifically, we can't really give you advice here. Herald / Mail are absolutely never the correct answer. Doorkeeper, Harbormaster, Feed Hooks, all available out of the box.
For now I have a ugly idea: Change content in PhabricatorMailImplementationPHPMailerAdapter.php and add some lines to invoke another python class of my own.
Apr 17 2017
Hmm ok. I think that I'm not usually listed explicitly as a reviewer, which means that Reviewers: #some_project_that_i_am_a_member_of doesn't include me. Would you be in favor of adding a new [Differential was reviewed by] field to Herald?
I don't think this behavior has changed. This has always meant "reviewers", not "reviewers who accepted the revision".
Apr 5 2017
Feb 23 2017
Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.
Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.
Feb 22 2017
Feb 13 2017
Feb 2 2017
Jan 18 2017
D17221 adds an "Auditors" field to Herald.
Jan 10 2017
Jan 2 2017
Dec 13 2016
Dec 8 2016
- H140
- {H140}
- H141
- H141 force chad
Dec 5 2016
T11953 isn't exactly the same as this, although they're similar.
Nov 17 2016
Nov 16 2016
From T11878, these patterns aren't obvious:
Oct 12 2016
Sep 30 2016
Sep 16 2016
Nuance is our plan for routing tasks, we don't anticipate needing this functionality in Herald.
Ok, read that. Here is a breakdown of our wishes and what we did to implement them:
Sep 15 2016
Sep 14 2016
Please read and follow Contributing Feature Requests.