Page MenuHomePhabricator
Feed Advanced Search

Jan 25 2018

epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18931: Document the new "only if this didn't match last time" Herald action setting.
Jan 25 2018, 6:19 PM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18930: Implement an "only if the rule did not match last time" policy for Herald rules.
Jan 25 2018, 5:52 PM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18927: Convert storage for Herald repetition policy to "text32".
Jan 25 2018, 4:28 AM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18926: Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule.
Jan 25 2018, 4:10 AM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18925: Define available Herald rule repetition options in terms of "isSingleEventAdapter()".
Jan 25 2018, 3:42 AM · Herald
epriestley updated the task description for T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald.
Jan 25 2018, 3:32 AM · Herald
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: D18924: Remove a very old Herald garbage collection migration.
Jan 25 2018, 3:28 AM · Herald
epriestley triaged T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald as Normal priority.
Jan 25 2018, 3:24 AM · Herald

Jan 18 2018

epriestley triaged T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated as Low priority.
Jan 18 2018, 2:58 PM · Diffusion, Herald

Jan 9 2018

epriestley triaged T13039: Support numeric fields in Herald as Low priority.
Jan 9 2018, 4:54 PM · Herald

Jan 4 2018

epriestley closed T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default as Resolved by committing rP53b25db91856: Prevent enormous changes from being pushed to repositoires by default.
Jan 4 2018, 6:02 PM · Herald, Security, Diffusion

Dec 26 2017

epriestley closed T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to as Resolved by committing rPead5f4fd9c03: Add an "Accepting reviewers" Herald field for commits.
Dec 26 2017, 11:59 PM · Differential, Herald, Bug Report
epriestley added a revision to T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default: D18850: Prevent enormous changes from being pushed to repositoires by default.
Dec 26 2017, 7:10 PM · Herald, Security, Diffusion
epriestley added a comment to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.

The fix for T13031 may have made this worse by default, since we now extract all pushed changesets and hold them in memory by default, even if no Herald content-based rules which use them actually exist. This may create too much memory pressure if you push a very large number of commits.

Dec 26 2017, 7:03 PM · Restricted Project, Diffusion, Herald

Dec 22 2017

epriestley added a revision to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to: D18839: Add an "Accepting reviewers" Herald field for commits.
Dec 22 2017, 6:19 PM · Differential, Herald, Bug Report

Dec 18 2017

epriestley added a comment to T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default.

Adjacently, some other parts of the UI currently use the word "enormous" (see https://discourse.phabricator-community.org/t/herald-enormous-check/822). They should be rewritten to use different language (like "Very Large"). We should use the term "Enormous" to mean only "too large to process completely", while the other UI uses it to mean "large enough to partially collapse for viewer convenience".

Dec 18 2017, 4:48 PM · Herald, Security, Diffusion
epriestley triaged T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default as Normal priority.
Dec 18 2017, 4:45 PM · Herald, Security, Diffusion
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

Also, while it's on my mind, all repositories should probably have this rule today:

Dec 18 2017, 4:37 PM · Restricted Project, Herald
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See T7789 and D18827. Block Git LFS in some repositories:

Dec 18 2017, 4:32 PM · Restricted Project, Herald
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See PHI242. SR Latch:

Dec 18 2017, 4:31 PM · Restricted Project, Herald

Dec 5 2017

epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Resolved by committing rP6d3baa92f908: Execute Herald again after promoting revisions out of the "Draft" state.
Dec 5 2017, 8:14 PM · Herald, Differential
epriestley added a revision to T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit: D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Dec 5 2017, 3:57 PM · Herald, Differential

Dec 1 2017

epriestley triaged T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Normal priority.
Dec 1 2017, 7:32 PM · Herald, Differential

Nov 23 2017

sshannin added a comment to T7703: Policy checks may execute incompletely for non-viewers.

I'm unable to close this, but I believe this to be resolved (or at least my specific repro of flags via herald no longer applies I believe).

Nov 23 2017, 3:37 AM · Policy, Herald, Flags

Oct 31 2017

epriestley added a comment to T10109: Differental does not trigger Herald for mundane updates.

Ah, thanks. I think your guess is right. I'll make a note in T2543, should be a one-line fix I think.

Oct 31 2017, 1:51 PM · Differential, Restricted Project, Herald, Bug Report
avivey added a comment to T10109: Differental does not trigger Herald for mundane updates.

From https://discourse.phabricator-community.org/t/644 - it appears that HM now triggers a build on revisions when they are closed via landing, which fails because the build expects a Staging ref. I don't have the setup to test any of it, but the latest revision landed here doesn't show the behavior, so either f7f3dd5b2084 hasn't rolled in here yet, or that user is doing something funny.

Oct 31 2017, 11:09 AM · Differential, Restricted Project, Herald, Bug Report

Oct 27 2017

epriestley closed T10109: Differental does not trigger Herald for mundane updates as Resolved by committing rPf7f3dd5b2084: Don't run Herald build and mail rules when they don't make sense.
Oct 27 2017, 3:44 PM · Differential, Restricted Project, Herald, Bug Report
svr678 added a comment to T5015: Allow Herald rules for Maniphest to act on task status changes.

oh, nice work, it will trigger parent task as well when subtask changed, seems I need to add the "condition" like subtask status instead of a "action" for this... any samples? Thanks!

Oct 27 2017, 3:17 AM · Maniphest, Herald

Oct 26 2017

svr678 added a comment to T5015: Allow Herald rules for Maniphest to act on task status changes.

Question: When subtask was fixed, the parent task want to have a action, for example, add a tag or change status if all subtasks were fixed.
So how to get this work in the extention of herald action? Thanks in advance!~

Oct 26 2017, 8:42 AM · Maniphest, Herald

Oct 24 2017

epriestley added a revision to T10109: Differental does not trigger Herald for mundane updates: D18731: Don't run Herald build and mail rules when they don't make sense.
Oct 24 2017, 9:21 PM · Differential, Restricted Project, Herald, Bug Report

Oct 4 2017

epriestley updated subscribers of T5016: Allow Herald rules for Maniphest to act on custom task fields.

The best place for this kind of question is now your organization's support pact -- @tammybutow or @alexmv should be able to help you get access.

Oct 4 2017, 11:34 PM · Custom Fields, Herald
ahoffer2 added a comment to T5016: Allow Herald rules for Maniphest to act on custom task fields.

@epriestley so maybe this isn't the right place to leave this comment (let me know if I should create a new task?) but I'm finding this is acting in a way that seems a bit inconsistent. In particular, I added a new boolean custom field --

Oct 4 2017, 9:24 PM · Custom Fields, Herald

Aug 25 2017

epriestley closed T5656: Add "Create Similar Rule..." to Herald as Wontfix.

Herald rules are now always public, which possibly addresses the original issue.

Aug 25 2017, 2:42 PM · Restricted Project, Herald

Aug 21 2017

chad placed T7729: No Typeahead on Herald object rule creation up for grabs.
Aug 21 2017, 6:10 PM · Typeahead, Herald

Aug 6 2017

chad added a comment to T7729: No Typeahead on Herald object rule creation.

oh thanks!

Aug 6 2017, 3:36 PM · Typeahead, Herald
epriestley reopened T7729: No Typeahead on Herald object rule creation as "Open".

I don't think this is resolved, just an unclear report. To access this screen:

Aug 6 2017, 11:50 AM · Typeahead, Herald
chad closed T7729: No Typeahead on Herald object rule creation as Resolved.

image.png (1×2 px, 218 KB)

Aug 6 2017, 3:59 AM · Typeahead, Herald
chad closed T8635: Show history of changes to Herald rules as Resolved.

image.png (1×2 px, 311 KB)

Aug 6 2017, 3:49 AM · Restricted Project, Herald

Jul 9 2017

chad removed the image for Herald.
Jul 9 2017, 7:36 PM

Jul 8 2017

avivey added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Methinks that the Rube Goldberg solution for this would be to get unittest.skip to have another argument with a task number, and then validate with lint/runtime that it look like T1234. And then maybe grep the body of the ticket for the filename.

Jul 8 2017, 4:03 AM · Herald, Feature Request
csilvers added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?

Jul 8 2017, 3:06 AM · Herald, Feature Request
epriestley added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

That is, I think the right tool for the job is either runtime enforcement or lint enforcement: make unittest.skip() with no reason fail (so the tests don't pass) or make lint raise a warning like "unittest.skip() must have a comment above it explaining the plan for re-enabling the test.".

Jul 8 2017, 12:55 AM · Herald, Feature Request
epriestley added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Can you change the syntax to something like @unittest.skip("Reasoning behind this decision...")?

Jul 8 2017, 12:46 AM · Herald, Feature Request
csilvers added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

I know about T9853, but if there's still a chance you might consider merging that upstream, there are a few folks here at Khan Academy who are excited by the feature. Here's one example:

Jul 8 2017, 12:40 AM · Herald, Feature Request

Jun 20 2017

epriestley added a comment to T920: Provide SMS Support.

Yeah, I'm pretty pessimistic about the security of SMS (or voice) as a factor. See also T7639 and T6549#97130. The article identifies these vectors:

Jun 20 2017, 11:51 AM · Restricted Project, Herald
20after4 added a comment to T920: Provide SMS Support.

https://www.wired.com/2016/06/hey-stop-using-texts-two-factor-authentication/

Jun 20 2017, 7:44 AM · Restricted Project, Herald

Jun 13 2017

Luke081515.2 added a comment to T12821: Herald should allow "only the first time the rule matches" for calendar events as well.

Thanks :)

Jun 13 2017, 8:43 PM · Herald, Bug Report

Jun 12 2017

epriestley closed T12821: Herald should allow "only the first time the rule matches" for calendar events as well as Resolved by committing rP0610b86f57d0: Allow Herald rules to apply "only the first time" to Calendar events.
Jun 12 2017, 6:23 PM · Herald, Bug Report
epriestley added a revision to T12821: Herald should allow "only the first time the rule matches" for calendar events as well: D18117: Allow Herald rules to apply "only the first time" to Calendar events.
Jun 12 2017, 2:46 PM · Herald, Bug Report

Jun 10 2017

Luke081515.2 created T12821: Herald should allow "only the first time the rule matches" for calendar events as well.
Jun 10 2017, 5:51 PM · Herald, Bug Report

May 31 2017

avivey added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

From T12771:

Global Rule for Differential Diffs
When:
[ Repository ] [ does not exist ]
Take these actions:
[ Block diff with message ] [ "Repository unrecognized. See https://helpful-docs.com/repository-help for details." ]

May 31 2017, 6:22 PM · Restricted Project, Herald

May 18 2017

chad added a comment to Q620: How to run custom tasks with Herald Rules?.

We have lots of APIs for external things, but without knowing what you're trying to do specifically, we can't really give you advice here. Herald / Mail are absolutely never the correct answer. Doorkeeper, Harbormaster, Feed Hooks, all available out of the box.

May 18 2017, 3:50 PM · Herald
chad changed the visibility for Q620: How to run custom tasks with Herald Rules?.
May 18 2017, 7:26 AM · Herald
dgzzhb added a comment to Q620: How to run custom tasks with Herald Rules?.

For now I have a ugly idea: Change content in PhabricatorMailImplementationPHPMailerAdapter.php and add some lines to invoke another python class of my own.

May 18 2017, 4:06 AM · Herald
dgzzhb asked Q620: How to run custom tasks with Herald Rules?.
May 18 2017, 3:40 AM · Herald

Apr 17 2017

joshuaspence updated the task description for T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.
Apr 17 2017, 11:15 PM · Differential, Herald, Bug Report
joshuaspence added a comment to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.

Hmm ok. I think that I'm not usually listed explicitly as a reviewer, which means that Reviewers: #some_project_that_i_am_a_member_of doesn't include me. Would you be in favor of adding a new [Differential was reviewed by] field to Herald?

Apr 17 2017, 10:56 PM · Differential, Herald, Bug Report
epriestley added a comment to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.

I don't think this behavior has changed. This has always meant "reviewers", not "reviewers who accepted the revision".

Apr 17 2017, 10:50 PM · Differential, Herald, Bug Report
joshuaspence created T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to.
Apr 17 2017, 10:48 PM · Differential, Herald, Bug Report

Apr 5 2017

cspeckmim updated the task description for T12507: User does not know why they received email based on Herald rule.
Apr 5 2017, 7:30 PM · Mail, Herald, Feature Request
cspeckmim created T12507: User does not know why they received email based on Herald rule.
Apr 5 2017, 7:22 PM · Mail, Herald, Feature Request

Feb 23 2017

epriestley added a comment to T12304: Herald fails to add auditors if the author is an auditor.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.

Feb 23 2017, 11:37 PM · Herald, Bug Report
epriestley added a comment to T12302: Herald adding different auditors but only the last one is kept.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.

Feb 23 2017, 11:36 PM · Herald, Bug Report
epriestley closed T12304: Herald fails to add auditors if the author is an auditor as Resolved by committing rP89d1403fe89d: Explicitly decline to add commit authors as auditors from Herald.
Feb 23 2017, 11:19 PM · Herald, Bug Report
epriestley closed T12302: Herald adding different auditors but only the last one is kept as Resolved by committing rP3b6a651b69fe: Merge multiple Auditors transactions from Herald.
Feb 23 2017, 11:15 PM · Herald, Bug Report
epriestley added a revision to T12304: Herald fails to add auditors if the author is an auditor: D17404: Explicitly decline to add commit authors as auditors from Herald.
Feb 23 2017, 10:47 PM · Herald, Bug Report
epriestley added a revision to T12302: Herald adding different auditors but only the last one is kept: D17403: Merge multiple Auditors transactions from Herald.
Feb 23 2017, 10:44 PM · Herald, Bug Report

Feb 22 2017

chad added a project to T12302: Herald adding different auditors but only the last one is kept: Herald.
Feb 22 2017, 8:59 PM · Herald, Bug Report
chad added a project to T12304: Herald fails to add auditors if the author is an auditor: Herald.
Feb 22 2017, 8:59 PM · Herald, Bug Report

Feb 13 2017

epriestley created T12257: Add an "author email" field to the "Differential Diff" Herald rule.
Feb 13 2017, 8:42 PM · KDE, Herald, Differential

Feb 2 2017

epriestley moved T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:50 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley moved T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) from Backlog to git push = save changes on the Diffusion (v3) board.
Feb 2 2017, 3:50 PM · Diffusion, Herald, Bug Report

Jan 18 2017

epriestley moved T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley moved T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) from Backlog to v3 on the Diffusion board.
Jan 18 2017, 6:59 PM · Diffusion, Herald, Bug Report
epriestley closed T5889: Allow herald rules to act on existence of auditors as Resolved by committing rP545dad319ec0: Add an "Auditors" rule for Commits.
Jan 18 2017, 6:05 PM · Restricted Project, Audit, Herald
epriestley added a comment to T5889: Allow herald rules to act on existence of auditors.

D17221 adds an "Auditors" field to Herald.

Jan 18 2017, 5:54 PM · Restricted Project, Audit, Herald
epriestley added a revision to T5889: Allow herald rules to act on existence of auditors: D17221: Add an "Auditors" rule for Commits.
Jan 18 2017, 5:53 PM · Restricted Project, Audit, Herald

Jan 10 2017

epriestley moved T11118: Herald Rule to assign Owners to an Audit from Backlog to Future on the Audit board.
Jan 10 2017, 4:51 PM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley moved T5889: Allow herald rules to act on existence of auditors from Backlog to Herald on the Audit board.
Jan 10 2017, 4:42 PM · Restricted Project, Audit, Herald

Jan 2 2017

joshuaspence added projects to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward): Diffusion, Herald.
Jan 2 2017, 10:26 AM · Diffusion, Herald, Bug Report

Dec 13 2016

epriestley added a project to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches: Diffusion.
Dec 13 2016, 4:40 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Dec 8 2016

epriestley closed T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task as Resolved by committing rPbe4f66a5a329: In Remarkup, render archived Herald rules with strikethrough for consistency.
Dec 8 2016, 8:37 PM · Herald, Feature Request
epriestley added a revision to T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task: D17010: In Remarkup, render archived Herald rules with strikethrough for consistency.
Dec 8 2016, 7:25 PM · Herald, Feature Request
epriestley claimed T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task.
Dec 8 2016, 7:24 PM · Herald, Feature Request
epriestley added a comment to T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task.
Dec 8 2016, 7:22 PM · Herald, Feature Request
aklapper created T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task.
Dec 8 2016, 7:21 PM · Herald, Feature Request

Dec 5 2016

epriestley added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

T11953 isn't exactly the same as this, although they're similar.

Dec 5 2016, 11:23 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley merged T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) into T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
Dec 5 2016, 11:20 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Nov 17 2016

chad closed Q520: How to automatic move maniphests on workboard of other project after a workboard movement as resolved.
Nov 17 2016, 2:54 PM · Workboards, Herald
dmgarcia updated Q520: How to automatic move maniphests on workboard of other project after a workboard movement from to How to automatic move maniphests on workboard of other project after a workboard movement.
Nov 17 2016, 2:24 PM · Workboards, Herald

Nov 16 2016

epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

From T11878, these patterns aren't obvious:

Nov 16 2016, 3:48 PM · Restricted Project, Herald

Oct 12 2016

kevinq updated Q499: Can you disable manual triggering of a build plan? from to Can you disable manual triggering of a build plan?.
Oct 12 2016, 1:42 PM · Herald, Harbormaster

Sep 30 2016

eadler moved T8336: Make a workflow that integrates nicely with list based email/patch reviews from Backlog to Important on the llvm board.
Sep 30 2016, 7:07 AM · llvm, FreeBSD, Herald
eadler added a project to T8336: Make a workflow that integrates nicely with list based email/patch reviews: llvm.
Sep 30 2016, 7:07 AM · llvm, FreeBSD, Herald

Sep 16 2016

chad added a comment to T11636: Herald condition: count of project tags.

Nuance is our plan for routing tasks, we don't anticipate needing this functionality in Herald.

Sep 16 2016, 5:32 PM · Herald, Feature Request
maxie added a comment to T11636: Herald condition: count of project tags.

Ok, read that. Here is a breakdown of our wishes and what we did to implement them:

Sep 16 2016, 2:34 PM · Herald, Feature Request

Sep 15 2016

eadler added a project to T8644: Herald template / recipe book / examples / quick-create tool: Restricted Project.
Sep 15 2016, 6:10 PM · Restricted Project, Herald
eadler added a project to T11118: Herald Rule to assign Owners to an Audit: Restricted Project.
Sep 15 2016, 6:09 PM · Restricted Project, Audit, Herald, Owners, Feature Request
eadler added a project to T11349: Herald has the wrong list of "Author's Projects": Restricted Project.
Sep 15 2016, 6:03 PM · Restricted Project, Herald, Bug Report

Sep 14 2016

chad closed T11636: Herald condition: count of project tags as Invalid.

Please read and follow Contributing Feature Requests.

Sep 14 2016, 3:48 PM · Herald, Feature Request