HomePhabricator

Merge multiple Auditors transactions from Herald

Description

Merge multiple Auditors transactions from Herald

Summary:
Fixes T12302. Currently, we aren't merging multiple "AddAuditors" transactions correctly.

This can occur when Herald triggers multiple auditor rules.

Instead, merge them.

Test Plan:

  • Wrote two different Herald rules that add auditors.
  • Pushed a commit which triggered them.
  • After the change, saw all the auditors get added correctly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12302

Differential Revision: https://secure.phabricator.com/D17403

Details

Provenance
epriestleyAuthored on Feb 23 2017, 10:42 PM
epriestleyPushed on Feb 23 2017, 11:15 PM
Reviewer
chad
Differential Revision
D17403: Merge multiple Auditors transactions from Herald
Parents
rP3eae9a368de0: Modular Transactions for Badges
Branches
Unknown
Tags
Unknown
Tasks
T12302: Herald adding different auditors but only the last one is kept
Build Status
Buildable 15748
Build 20812: Run Core Tests