Page MenuHomePhabricator

Add an "Auditors" rule for Commits
ClosedPublic

Authored by epriestley on Jan 18 2017, 5:53 PM.
Tags
None
Referenced Files
F15469121: D17221.diff
Fri, Apr 4, 9:22 AM
F15454052: D17221.id41421.diff
Sat, Mar 29, 4:00 PM
F15446967: D17221.diff
Thu, Mar 27, 9:07 PM
F15445965: D17221.id.diff
Thu, Mar 27, 4:46 PM
F15427924: D17221.id41421.diff
Sun, Mar 23, 5:14 PM
F15381081: D17221.id.diff
Fri, Mar 14, 5:46 AM
F15311878: D17221.diff
Mar 6 2025, 11:54 AM
F15311733: D17221.diff
Mar 6 2025, 10:32 AM
Subscribers
None

Details

Summary

Fixes T5889. You can't write a rule like "if no other Herald rules did anything...", but you can use this rule to check for Owners or an explicit "Auditors" field doing things.

Test Plan

Using the test console, ran an "Auditors" rule against a commit with and without an auditor. Got expected pass/fail outcomes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable