Page MenuHomePhabricator

Merge multiple Auditors transactions from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:44 PM.
Tags
None
Referenced Files
F18652023: D17403.diff
Sun, Sep 21, 6:21 AM
F18651427: D17403.diff
Sun, Sep 21, 4:22 AM
Unknown Object (File)
May 8 2025, 4:46 PM
Unknown Object (File)
May 7 2025, 1:16 PM
Unknown Object (File)
Apr 30 2025, 7:58 AM
Unknown Object (File)
Apr 28 2025, 12:03 AM
Unknown Object (File)
Apr 15 2025, 5:46 PM
Unknown Object (File)
Apr 10 2025, 5:25 PM
Subscribers
None

Details

Summary

Fixes T12302. Currently, we aren't merging multiple "AddAuditors" transactions correctly.

This can occur when Herald triggers multiple auditor rules.

Instead, merge them.

Test Plan
  • Wrote two different Herald rules that add auditors.
  • Pushed a commit which triggered them.
  • After the change, saw all the auditors get added correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 23 2017, 11:11 PM
This revision was automatically updated to reflect the committed changes.