Page MenuHomePhabricator

Merge multiple Auditors transactions from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:44 PM.
Tags
None
Referenced Files
F15507241: D17403.diff
Tue, Apr 15, 5:46 PM
F15487853: D17403.id41851.diff
Thu, Apr 10, 5:25 PM
F15486176: D17403.id41849.diff
Thu, Apr 10, 5:26 AM
F15475158: D17403.id.diff
Sun, Apr 6, 4:39 PM
F15472380: D17403.diff
Sat, Apr 5, 12:54 PM
F15426893: D17403.id.diff
Mar 23 2025, 11:29 AM
F15414802: D17403.id41849.diff
Mar 20 2025, 2:35 AM
F15411587: D17403.id41851.diff
Mar 19 2025, 9:28 AM
Subscribers
None

Details

Summary

Fixes T12302. Currently, we aren't merging multiple "AddAuditors" transactions correctly.

This can occur when Herald triggers multiple auditor rules.

Instead, merge them.

Test Plan
  • Wrote two different Herald rules that add auditors.
  • Pushed a commit which triggered them.
  • After the change, saw all the auditors get added correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 23 2017, 11:11 PM
This revision was automatically updated to reflect the committed changes.