Page MenuHomePhabricator

Don't run Herald build and mail rules when they don't make sense
ClosedPublic

Authored by epriestley on Oct 24 2017, 9:21 PM.

Details

Summary

Ref T2543. Fixes T10109.

Currently, Herald only runs in Differential when a change updates the diff. This is partly for historical reasons, and partly because we don't want to restart builds every time someone makes a comment. However, this behavior is inconsistent with other applications (which always trigger on any change), and occasionally confusing to users (in T10109, for example) or otherwise undesirable.

A similar issue is that T2543 has introduced a "Draft" state, where revisions don't send normal mail until builds finish. This interacts poorly with "Send me an email" rules (which shouldn't do anything here) and particularly with "Send me an email + only run these actions the first time the rule matches", since that might have an effect like "do nothing when the revision is created, then never anything again since you already did nothing once".

To navigate both of these issues, let objects tell Herald that certain actions (like mail or builds) are currently forbidden. If a rule uses a field or action which is currently forbidden, the whole rule automatically fails before it executes, but doesn't count toward "only the first time" as far as Herald's tracking of rule execution is concerned.

Then, forbid mail for draft revisions, and forbid builds for revisions which didn't just get updated. Forbidding mail fixes the issues with "Send me an email" that were created by the introduction of the draft state.

Finally, make Herald run on every revision update, not just substantive updates to the diff. This resolves T10109.

Test Plan

Created revisions via the draft -> submit workflow, saw different transcripts. Here's a mail action being forbidden for a draft:

Here's a build action being forbidden for a "mundane" update:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 24 2017, 9:21 PM
Owners added a subscriber: Restricted Owners Package.Oct 24 2017, 9:21 PM
Harbormaster requested review of this revision.Oct 24 2017, 9:22 PM
Harbormaster completed remote builds in B18742: Diff 44961.
amckinley accepted this revision.Oct 27 2017, 1:26 AM
This revision is now accepted and ready to land.Oct 27 2017, 1:26 AM
This revision was automatically updated to reflect the committed changes.