We are using a remotely hosted SVN server, with phabricator "observing" it. I have set up herald to add auditors if anyone commits on a certain repository. In one particular case, it would add 3 auditors. This works fine unless one of those 3 auditors is also the author of the commit. In this case no auditors get added.
Reproduction
- Set up repository (remotely hosted SVN)
- Add multiple auditors in herald when a commit is made
- Have someone else commit - this should work
- Have one of the auditors commit - this fails
Herald transcripts
In this case robert.white committed a test commit onto rCC. He was also set up as an auditor
H13 Cable Canary Conditions Passed Repository is any of rCC Passed Affected files does not match regexp @desktop_and_web/scripts@ Passed Rule passed. Action: Add auditors Added Auditors Added auditors: robert.white, • wp, szh.
Herald shows the auditors as being added, but if you look in the commit, there are no auditors.
Now, robert.white has been removed as an auditor and he committed another test commit.
H13 Cable Canary Conditions Passed Repository is any of rCC Passed Affected files does not match regexp @desktop_and_web/scripts@ Passed Rule passed. Action: Add auditors Added Auditors Added auditors: • wp, szh.
Herald shows the auditors (not including robert.white) being added. Looking in the commit, the auditors wp and szh are added properly.
Version information
phabricator e2868a0da24c96059211d1ed54df3ebad86b53bd (Tue, Feb 21)
arcanist 3b6b523c2b236e3724a1e115f126cb6fd05fa128 (Sat, Feb 18)
phutil ef580c9ccc219b9871588921f545a7609d2b01dc (Sun, Feb 19)