Page MenuHomePhabricator
Differential D18930

Implement an "only if the rule did not match last time" policy for Herald rules
ClosedPublic
Actions

Authored by epriestley on Jan 25 2018, 5:52 PM.
Tags
None
Referenced Files
F18695562: D18930.diff
Sat, Sep 27, 6:03 AM
F18566492: D18930.id.diff
Tue, Sep 9, 2:40 PM
F18502007: D18930.diff
Thu, Sep 4, 10:07 PM
F18099464: D18930.id45400.diff
Aug 9 2025, 5:11 AM
F18097119: D18930.id.diff
Aug 8 2025, 11:12 AM
F18095342: D18930.id45423.diff
Aug 7 2025, 11:12 PM
F18091506: D18930.diff
Aug 6 2025, 10:11 PM
F18052077: D18930.id45400.diff
Aug 4 2025, 1:22 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald
Commits
rPa34b6bdd06b7: Implement an "only if the rule did not match last time" policy for Herald rules
Summary

Depends on D18927. Ref T13048. This implements a new policy which allows Herald rules to fire on some kinds of state changes.

Test Plan

Wrote and tested rules with the new policy:

Screen Shot 2018-01-25 at 8.10.46 AM.png (1×2 px, 186 KB)

Screen Shot 2018-01-25 at 8.10.36 AM.png (1×2 px, 253 KB)

Also wrote and tested rules with the old policies:

Screen Shot 2018-01-25 at 8.19.44 AM.png (1×2 px, 184 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
14 lines
controller/
2 lines
engine/
98 lines
storage/
12 lines

Diff 45423

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/engine/HeraldEngine.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility