Page MenuHomePhabricator

Implement an "only if the rule did not match last time" policy for Herald rules
ClosedPublic

Authored by epriestley on Jan 25 2018, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 8:51 AM
Unknown Object (File)
Feb 16 2024, 8:34 PM
Unknown Object (File)
Feb 11 2024, 6:34 AM
Unknown Object (File)
Jan 31 2024, 11:17 AM
Unknown Object (File)
Jan 22 2024, 11:38 PM
Unknown Object (File)
Jan 7 2024, 5:36 AM
Unknown Object (File)
Dec 27 2023, 12:40 PM
Unknown Object (File)
Dec 21 2023, 11:06 PM
Subscribers
None

Details

Summary

Depends on D18927. Ref T13048. This implements a new policy which allows Herald rules to fire on some kinds of state changes.

Test Plan

Wrote and tested rules with the new policy:

Screen Shot 2018-01-25 at 8.10.46 AM.png (1×2 px, 186 KB)

Screen Shot 2018-01-25 at 8.10.36 AM.png (1×2 px, 253 KB)

Also wrote and tested rules with the old policies:

Screen Shot 2018-01-25 at 8.19.44 AM.png (1×2 px, 184 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable