Page MenuHomePhabricator

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic

Authored by epriestley on Feb 23 2017, 10:47 PM.
Tags
None
Referenced Files
F15540031: D17404.id.diff
Fri, Apr 25, 6:26 AM
F15535544: D17404.id.diff
Thu, Apr 24, 5:41 AM
F15530874: D17404.diff
Wed, Apr 23, 7:34 AM
F15471894: D17404.id41850.diff
Sat, Apr 5, 9:06 AM
F15471811: D17404.diff
Sat, Apr 5, 8:12 AM
F15442163: D17404.id41852.diff
Mar 26 2025, 9:53 PM
F15437566: D17404.id41850.diff
Mar 25 2025, 8:27 PM
F15430198: D17404.id.diff
Mar 24 2025, 6:26 AM
Subscribers
None

Details

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan
  • Wrote a Herald rule to add A, B and C as auditors.
  • Committed as A.
  • After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable