Differential D17404

Explicitly decline to add commit authors as auditors from Herald
ClosedPublic
Actions

Authored by epriestley on Feb 23 2017, 10:47 PM.

Details

Reviewers

chad

Maniphest Tasks

T12304: Herald fails to add auditors if the author is an auditor

Commits

rP89d1403fe89d: Explicitly decline to add commit authors as auditors from Herald

Summary

Fixes T12304. If you have a Herald rule which tries to add a commit author as an auditor, it fails validation when trying to apply.

Stop trying to apply these transactions, and explicitly tell the user why. Differential already uses a similar ruleset around reviewers, but Audit was using older code.

Test Plan

Wrote a Herald rule to add A, B and C as auditors.
Committed as A.
After change, saw B and C added with transacript guidance that A was the author.

Screen Shot 2017-02-23 at 2.42.02 PM.png (201×540 px, 33 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 23 2017, 10:47 PM

Harbormaster completed remote builds in B15747: Diff 41850.Feb 23 2017, 10:48 PM

chad accepted this revision.Feb 23 2017, 11:12 PM

This revision is now accepted and ready to land.Feb 23 2017, 11:12 PM

Closed by commit rP89d1403fe89d: Explicitly decline to add commit authors as auditors from Herald (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2017, 11:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12406: Importing commits which name themselves as the auditor can cause stuck tasks.Mar 16 2017, 5:19 AM

mchamati mentioned this in Z1336: General Chat.May 5 2017, 3:41 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

herald/

DiffusionAuditorsHeraldAction.php

26 lines

Diff 41852

View Options

src/applications/diffusion/herald/DiffusionAuditorsHeraldAction.php

Explicitly decline to add commit authors as auditors from HeraldClosedPublicActions