Page MenuHomePhabricator
Differential D18117

Allow Herald rules to apply "only the first time" to Calendar events
ClosedPublic
Actions

Authored by epriestley on Jun 12 2017, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 4:18 AM
Unknown Object (File)
Sun, Feb 9, 4:18 AM
Unknown Object (File)
Sun, Feb 9, 4:18 AM
Unknown Object (File)
Fri, Jan 24, 9:33 PM
Unknown Object (File)
Fri, Jan 24, 9:33 PM
Unknown Object (File)
Fri, Jan 24, 9:33 PM
Unknown Object (File)
Tue, Jan 21, 11:04 AM
Unknown Object (File)
Dec 30 2024, 7:18 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12821: Herald should allow "only the first time the rule matches" for calendar events as well
Commits
rP0610b86f57d0: Allow Herald rules to apply "only the first time" to Calendar events
Summary

Fixes T12821. (Some events only happen once, so the default behavior doesn't let you pick this rule, and objects must opt into it by saying "yeah, I support multiple edits".)

Test Plan

Note "only the first time" selected:

Screen Shot 2017-06-12 at 7.46.16 AM.png (682×522 px, 46 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 12 2017, 2:46 PM
Harbormaster completed remote builds in B17478: Diff 43580.Jun 12 2017, 2:47 PM
chad accepted this revision.Jun 12 2017, 4:45 PM
This revision is now accepted and ready to land.Jun 12 2017, 4:45 PM
Closed by commit rP0610b86f57d0: Allow Herald rules to apply "only the first time" to Calendar events (authored by epriestley, committed by epriestley). · Explain WhyJun 12 2017, 6:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
herald/
7 lines

Diff 43586

View Options

src/applications/calendar/herald/PhabricatorCalendarEventHeraldAdapter.php

Loading...
Phabricator · Built by Phacility