Page MenuHomePhabricator

Remove a very old Herald garbage collection migration
ClosedPublic

Authored by epriestley on Jan 25 2018, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 5:07 AM
Unknown Object (File)
Feb 25 2024, 7:59 PM
Unknown Object (File)
Feb 5 2024, 8:32 PM
Unknown Object (File)
Jan 7 2024, 4:58 PM
Unknown Object (File)
Dec 27 2023, 12:39 PM
Unknown Object (File)
Dec 21 2023, 11:05 PM
Unknown Object (File)
Dec 19 2023, 12:39 PM
Unknown Object (File)
Dec 2 2023, 9:32 PM
Subscribers
None

Details

Summary

Ref T13048. This migration is from January 2012 and probably only impacted Facebook.

It references HeraldRepetitionPolicyConfig, which I'd like to change significantly. I initially just replaced the constant with a literal 0, but I don't think there's any actual value in retaining this migration nowadays.

The cost of removing this migration is: if you installed Phabricator before January 2012 and haven't upgraded since then, you'll have a few more rows in the APPLIED table than necessary. Herald will still work correctly.

Test Plan

Reading.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable