Page MenuHomePhabricator

Remove a very old Herald garbage collection migration
ClosedPublic

Authored by epriestley on Jan 25 2018, 3:28 AM.
Tags
None
Referenced Files
F17944425: D18924.id.diff
Thu, Jul 31, 10:04 AM
F17937411: D18924.diff
Thu, Jul 31, 1:13 AM
F17798508: D18924.id45419.diff
Fri, Jul 25, 3:36 AM
F17754716: D18924.diff
Tue, Jul 22, 11:14 AM
Unknown Object (File)
Jun 18 2025, 11:53 AM
Unknown Object (File)
May 9 2025, 5:33 PM
Unknown Object (File)
Apr 27 2025, 5:54 AM
Unknown Object (File)
Apr 25 2025, 7:42 PM
Subscribers
None

Details

Summary

Ref T13048. This migration is from January 2012 and probably only impacted Facebook.

It references HeraldRepetitionPolicyConfig, which I'd like to change significantly. I initially just replaced the constant with a literal 0, but I don't think there's any actual value in retaining this migration nowadays.

The cost of removing this migration is: if you installed Phabricator before January 2012 and haven't upgraded since then, you'll have a few more rows in the APPLIED table than necessary. Herald will still work correctly.

Test Plan

Reading.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable