Page MenuHomePhabricator

Remove a very old Herald garbage collection migration
ClosedPublic

Authored by epriestley on Jan 25 2018, 3:28 AM.
Tags
None
Referenced Files
F18740252: D18924.id.diff
Thu, Oct 2, 1:26 AM
F18670220: D18924.id45419.diff
Wed, Sep 24, 11:28 PM
F18509250: D18924.id.diff
Fri, Sep 5, 3:18 AM
F18502002: D18924.diff
Thu, Sep 4, 10:07 PM
F18099269: D18924.id45392.diff
Aug 9 2025, 3:18 AM
F18090714: D18924.id.diff
Aug 6 2025, 5:11 PM
F18090565: D18924.id45392.diff
Aug 6 2025, 4:16 PM
F18090527: D18924.id45419.diff
Aug 6 2025, 4:09 PM
Subscribers
None

Details

Summary

Ref T13048. This migration is from January 2012 and probably only impacted Facebook.

It references HeraldRepetitionPolicyConfig, which I'd like to change significantly. I initially just replaced the constant with a literal 0, but I don't think there's any actual value in retaining this migration nowadays.

The cost of removing this migration is: if you installed Phabricator before January 2012 and haven't upgraded since then, you'll have a few more rows in the APPLIED table than necessary. Herald will still work correctly.

Test Plan

Reading.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable