Page MenuHomePhabricator

Remove a very old Herald garbage collection migration
ClosedPublic

Authored by epriestley on Jan 25 2018, 3:28 AM.
Tags
None
Referenced Files
F15468407: D18924.id45419.diff
Fri, Apr 4, 12:20 AM
F15461792: D18924.id45419.diff
Tue, Apr 1, 11:19 AM
F15424313: D18924.id45419.diff
Sat, Mar 22, 9:26 PM
F15415113: D18924.id45392.diff
Thu, Mar 20, 4:07 AM
F15409133: D18924.id45419.diff
Wed, Mar 19, 3:22 AM
F15409132: D18924.id45392.diff
Wed, Mar 19, 3:22 AM
F15409118: D18924.diff
Wed, Mar 19, 3:20 AM
F15405213: D18924.id.diff
Tue, Mar 18, 10:41 AM
Subscribers
None

Details

Summary

Ref T13048. This migration is from January 2012 and probably only impacted Facebook.

It references HeraldRepetitionPolicyConfig, which I'd like to change significantly. I initially just replaced the constant with a literal 0, but I don't think there's any actual value in retaining this migration nowadays.

The cost of removing this migration is: if you installed Phabricator before January 2012 and haven't upgraded since then, you'll have a few more rows in the APPLIED table than necessary. Herald will still work correctly.

Test Plan

Reading.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable