Page MenuHomePhabricator

Execute Herald again after promoting revisions out of the "Draft" state
ClosedPublic

Authored by epriestley on Dec 5 2017, 3:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 3:51 AM
Unknown Object (File)
Feb 1 2024, 11:41 PM
Unknown Object (File)
Jan 19 2024, 4:55 PM
Unknown Object (File)
Jan 15 2024, 8:06 PM
Unknown Object (File)
Jan 13 2024, 4:00 PM
Unknown Object (File)
Jan 10 2024, 7:17 PM
Unknown Object (File)
Jan 7 2024, 4:55 PM
Unknown Object (File)
Jan 3 2024, 8:04 PM
Subscribers
None

Details

Summary

Fixes T13027. Ref T2543. When revisions promote from "Draft" because builds finish or no builds are configured, the status currently switches from "Draft" to "Needs Review" without re-running Herald.

This means that some rules -- notably, "Send me an email" rules -- don't fire as soon as they should.

Instead of applying this promotion in a hacky way inline, queue it and apply it normally in a second edit, after the current group finishes.

Test Plan
  • Created a revision, reviewed Herald transcripts.
  • Saw three Herald passes:
    • First pass (revision creation) triggered builds and no email.
    • Second pass (builds finished) did not trigger builds (no update) and did not trigger email (revision still a draft).
    • Third pass (after promotion out of 'draft') did not trigger builds (no update) but did trigger email (revision no longer a draft).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable