Page MenuHomePhabricator

Herald adding different auditors but only the last one is kept
Closed, ResolvedPublic

Assigned To
Authored By
Feb 21 2017, 3:56 PM
Referenced Files
F3120241: 3.png
Feb 21 2017, 3:56 PM
F3120248: 4.png
Feb 21 2017, 3:56 PM
F3120236: 1.png
Feb 21 2017, 3:56 PM
F3120239: 2.png
Feb 21 2017, 3:56 PM
F3120250: 5.png
Feb 21 2017, 3:56 PM



This seems to be related to
We update from master weekly.

We have Herald rules in place that add auditors to commits, for example:

  1. [1.png]
    1.png (516×588 px, 25 KB)
  2. [2.png]
    2.png (498×516 px, 20 KB)
  3. [3.png]
    3.png (489×516 px, 20 KB)

Until now, some commits were affected by those 3 rules and therefore 3 different auditors were added.

After the update to latest version last week, the following happens:


4.png (758×1 px, 70 KB)

As you can see, Herald indicates that it's adding the different auditors but only the last one is kept.

Here you can see the Herald transcript:


5.png (596×594 px, 38 KB)

This is happening in every case where there should be more than one auditor.

Let me know if I can provide more details.


Event Timeline

Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.

Also, thanks for the clear, concise reproduction instructions: they were instrumental in reproducing and fixing this problem quickly.