Page MenuHomePhabricator
Feed All Stories

Mar 25 2019

epriestley closed D20318: Fix an unusual internal cursor in Conpherence.
Mar 25 2019, 5:53 PM
epriestley committed rP7f90570636af: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank >… (authored by epriestley).
When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank >…
Mar 25 2019, 5:52 PM
epriestley closed D20298: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank > ...".
Mar 25 2019, 5:52 PM
epriestley committed rPf047b90d9383: Don't draw the task graph line image on devices by default (authored by epriestley).
Don't draw the task graph line image on devices by default
Mar 25 2019, 5:52 PM
epriestley closed D20313: Don't draw the task graph line image on devices by default.
Mar 25 2019, 5:52 PM
epriestley requested review of D20321: When moving cards on workboards, treat before/after cards as optional hints, not strict requirements.
Mar 25 2019, 5:51 PM
epriestley added a revision to T12175: Simultaneous task moving on workboards results in error: D20321: When moving cards on workboards, treat before/after cards as optional hints, not strict requirements.
Mar 25 2019, 5:49 PM · Workboards (v3), Bug Report
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20321: When moving cards on workboards, treat before/after cards as optional hints, not strict requirements.
Mar 25 2019, 5:49 PM · Workboards (v3), Plans, Projects
epriestley added inline comments to D20318: Fix an unusual internal cursor in Conpherence.
Mar 25 2019, 5:46 PM
amckinley accepted D20318: Fix an unusual internal cursor in Conpherence.
Mar 25 2019, 5:39 PM
amckinley accepted D20313: Don't draw the task graph line image on devices by default.
Mar 25 2019, 5:37 PM
amckinley accepted D20314: Fix two minor timezone display issues.
Mar 25 2019, 5:37 PM
amckinley accepted D20319: Correct use of the paging API in Phame.
Mar 25 2019, 5:35 PM
epriestley claimed T12175: Simultaneous task moving on workboards results in error.
Mar 25 2019, 5:31 PM · Workboards (v3), Bug Report
amckinley accepted D20298: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank > ...".
Mar 25 2019, 5:30 PM
epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Mar 25 2019, 4:43 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

Simply adding two position rows on the same board doesn't reproduce the exact same error, we get this instead: [Unable to find...]

Mar 25 2019, 4:28 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

Make drops when a column position already exists go through.

Mar 25 2019, 4:24 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

See PHI119. This may describe a race fixed by chaos reduction in T13054. PHI1128 is probably another copy of this, which suggests it's still a real bug.
See PHI208. This describes a performance issue on workboards with very large numbers of tasks.

Mar 25 2019, 4:17 PM · Workboards (v3), Plans, Projects
epriestley requested review of D20320: Dim the action drop preview element when the cursor approaches.
Mar 25 2019, 3:10 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20320: Dim the action drop preview element when the cursor approaches.
Mar 25 2019, 3:09 PM · Workboards (v3), Restricted Project
epriestley requested review of D20319: Correct use of the paging API in Phame.
Mar 25 2019, 2:30 PM
epriestley added a revision to T13266: Upgrading: Minor Changes to Query Paging / Cursors: D20319: Correct use of the paging API in Phame.
Mar 25 2019, 2:30 PM · Installing & Upgrading
epriestley added a revision to T13263: Plans: 2019 Week 11-15 Bonus Content: D20319: Correct use of the paging API in Phame.
Mar 25 2019, 2:28 PM · Plans
aklapper removed a project from T5000: Using Differential with plain Git, without requiring Arc: Wikimedia.
Mar 25 2019, 1:10 AM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential

Mar 24 2019

epriestley requested review of D20318: Fix an unusual internal cursor in Conpherence.
Mar 24 2019, 9:00 PM
epriestley committed rPe51381e2d6fa: (stable) Fix transaction queries failing on "withIDs()" after clicking "Show… (authored by epriestley).
(stable) Fix transaction queries failing on "withIDs()" after clicking "Show…
Mar 24 2019, 7:26 PM
epriestley committed rPb82557073492: Fix transaction queries failing on "withIDs()" after clicking "Show Older" (authored by epriestley).
Fix transaction queries failing on "withIDs()" after clicking "Show Older"
Mar 24 2019, 7:25 PM
epriestley closed D20317: Fix transaction queries failing on "withIDs()" after clicking "Show Older".
Mar 24 2019, 7:25 PM
avivey accepted D20317: Fix transaction queries failing on "withIDs()" after clicking "Show Older".
Mar 24 2019, 6:45 PM
epriestley requested review of D20317: Fix transaction queries failing on "withIDs()" after clicking "Show Older".
Mar 24 2019, 2:54 PM

Mar 23 2019

thuffir added a comment to T11725: [Diffusion] Issue with checking out SVN repository while clone is successful for a Git repository.

Just ran into this issue on a freshly installed Ubuntu 16.04 docker container.
Actually it's just the package phpX.Y-xml what is missing.
In my case it was php7.2 so all I needed to do was:

sudo apt install php7.2-xml

(No extra repositories needed...)

Mar 23 2019, 11:11 PM · Bug Report (Needs Information)
epriestley committed rP3d481fb75772: (stable) Fix an issue with "nextPage()" on worker trigger queries (authored by epriestley).
(stable) Fix an issue with "nextPage()" on worker trigger queries
Mar 23 2019, 5:43 PM
epriestley committed rPf0ae75c9916a: Fix an issue with "nextPage()" on worker trigger queries (authored by epriestley).
Fix an issue with "nextPage()" on worker trigger queries
Mar 23 2019, 5:43 PM
epriestley updated the task description for T13267: Cluster daemons can spiral to death over contentious cache fills.
Mar 23 2019, 5:17 PM · Phacility
epriestley triaged T13267: Cluster daemons can spiral to death over contentious cache fills as Normal priority.
Mar 23 2019, 4:56 PM · Phacility
Harbormaster failed to build B22337: rP7477da3d4f5b: (stable) Promote 2019 Week 12 for rP7477da3d4f5b: (stable) Promote 2019 Week 12!
Mar 23 2019, 2:43 PM
epriestley edited the content of Changelog.
Mar 23 2019, 2:43 PM
epriestley committed rP7477da3d4f5b: (stable) Promote 2019 Week 12 (authored by epriestley).
(stable) Promote 2019 Week 12
Mar 23 2019, 2:41 PM
epriestley created 2019 Week 12 (Late March).
Mar 23 2019, 2:41 PM
epriestley committed rPaae7bdbbdd56: Reference raw "title" row in Phriction paging, not "c.title" (authored by epriestley).
Reference raw "title" row in Phriction paging, not "c.title"
Mar 23 2019, 2:29 PM
epriestley committed rPc16a8c7ab200: Fix a content join condition in Phriction (authored by epriestley).
Fix a content join condition in Phriction
Mar 23 2019, 2:18 PM

Mar 22 2019

epriestley requested review of D20316: Support exporting custom "Options/Select" fields to Excel/JSON/CSV/etc.
Mar 22 2019, 11:03 PM
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 22 2019, 10:36 PM · Plans
epriestley added inline comments to D20315: Provide a clearer UI for "view all results" in partial result panels.
Mar 22 2019, 10:35 PM
epriestley requested review of D20315: Provide a clearer UI for "view all results" in partial result panels.
Mar 22 2019, 10:34 PM
epriestley requested review of D20314: Fix two minor timezone display issues.
Mar 22 2019, 10:09 PM
epriestley added a revision to T13263: Plans: 2019 Week 11-15 Bonus Content: D20314: Fix two minor timezone display issues.
Mar 22 2019, 10:07 PM · Plans
epriestley requested review of D20313: Don't draw the task graph line image on devices by default.
Mar 22 2019, 5:00 PM
epriestley requested review of D20312: Don't show a "Manage" button in Legalpad if the user is signing a TOS document.
Mar 22 2019, 4:38 PM
epriestley requested review of D20311: Generalize Legalpad validation logic for "Require Signature".
Mar 22 2019, 4:29 PM
epriestley requested review of D20310: Make notifications visually clearer, like Feed.
Mar 22 2019, 4:16 PM
epriestley requested review of D20309: When a repository is inactive, mark its handle as "closed".
Mar 22 2019, 4:09 PM
epriestley requested review of D20308: Track how many columns use a particular trigger.
Mar 22 2019, 3:11 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20308: Track how many columns use a particular trigger.
Mar 22 2019, 3:10 PM · Workboards (v3), Restricted Project
epriestley requested review of D20307: Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans.
Mar 22 2019, 1:44 PM

Mar 21 2019

epriestley requested review of D20306: Add a "Play Sound" workboard trigger rule.
Mar 21 2019, 10:28 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20306: Add a "Play Sound" workboard trigger rule.
Mar 21 2019, 10:27 PM · Workboards (v3), Restricted Project
epriestley added a comment to T6415: Workboard drag and drop freezes indefinitely if it cannot access the server even temporarily.

After D20305, this can be "fixed" with this change:

Mar 21 2019, 8:47 PM · Workboards
epriestley requested review of D20305: If the user cancels a workboard drop flow, put things back where they were.
Mar 21 2019, 8:42 PM
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20305: If the user cancels a workboard drop flow, put things back where they were.
Mar 21 2019, 8:41 PM · Workboards (v3), Plans, Projects
epriestley requested review of D20304: When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip.
Mar 21 2019, 8:24 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20304: When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip.
Mar 21 2019, 8:24 PM · Workboards (v3), Restricted Project
epriestley requested review of D20303: Show a trigger rule summary on the rule view page.
Mar 21 2019, 7:32 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20303: Show a trigger rule summary on the rule view page.
Mar 21 2019, 7:31 PM · Workboards (v3), Restricted Project
epriestley abandoned D16859: Let Herald know when workboard cards have been moved to another column.

Presumably soon-to-be obsoleted by changes on T5474.

Mar 21 2019, 7:09 PM
epriestley commandeered D16859: Let Herald know when workboard cards have been moved to another column.
Mar 21 2019, 7:08 PM
epriestley closed T10336: Animate changes to workboards as Wontfix.

We may still pursue this, especially after T4900, but a lot of the use cases / needs are mostly theoretical and it's not clear they're actually necessary. Some of the actual solutions (like T10335) may largely provide enough clarity about these cases on their own. I'm currently planning to wait for feedback about recent and near-future changes (including triggers) and then fix whatever issues arise surgically -- possibly through animation, but possibly through other UI/UX remedies.

Mar 21 2019, 7:05 PM · Workboards (v3)
epriestley closed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint as Resolved.

Those changes haven't landed yet but I'm just going to tidy this up a little early, see T13074 for followups.

Mar 21 2019, 7:00 PM · Workboards (v3)
epriestley requested review of D20302: Write workboard trigger rules to the database.
Mar 21 2019, 6:53 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20302: Write workboard trigger rules to the database.
Mar 21 2019, 6:52 PM · Workboards (v3), Restricted Project
epriestley requested review of D20301: Mostly make the editor UI for triggers work.
Mar 21 2019, 4:44 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20301: Mostly make the editor UI for triggers work.
Mar 21 2019, 4:43 PM · Workboards (v3), Restricted Project
epriestley added a comment to D20046: Read "$_POST" before hooking the profiler, and remove "aphront.default-application-configuration-class".

Please report issues you encounter with Phabricator via Discourse, not by commenting here.

Mar 21 2019, 1:51 PM
Pawka added a comment to D20046: Read "$_POST" before hooking the profiler, and remove "aphront.default-application-configuration-class".

Looks like this patch broke serving Phabricator via php built-in server as __path__ variable is not available on $_POST after readHTTPPOSTData method is executed.

Mar 21 2019, 1:50 PM
kerberizer awarded T2334: Implement Google Calendar v3 API into Calendar a Love token.
Mar 21 2019, 9:09 AM · Restricted Project, Prioritized, Calendar

Mar 20 2019

epriestley requested review of D20300: Don't show workboard action previews if the action won't have any effect.
Mar 20 2019, 2:35 AM
epriestley added a revision to T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint: D20300: Don't show workboard action previews if the action won't have any effect.
Mar 20 2019, 2:33 AM · Workboards (v3)

Mar 19 2019

epriestley requested review of D20299: Preview the effects of a drag-and-drop operation on workboards.
Mar 19 2019, 11:10 PM
epriestley added a revision to T5474: Support workboard column triggers which activate when a task is dropped into a column: D20299: Preview the effects of a drag-and-drop operation on workboards.
Mar 19 2019, 11:09 PM · Workboards (v3), Restricted Project
epriestley added a revision to T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint: D20299: Preview the effects of a drag-and-drop operation on workboards.
Mar 19 2019, 11:09 PM · Workboards (v3)
epriestley claimed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint.
Mar 19 2019, 11:02 PM · Workboards (v3)
avivey added a comment to T13264: Maybe stack multiple breadcrumb sequences?.

We should log all the paths used to get to each page, and then show all of them in a big combo box, and when you select one, update your browser's history to match that path!

Mar 19 2019, 10:02 PM · Design
epriestley closed T13251: Upgrading: PhutilURI Query Parameter Changes as Resolved.

This seems to have quieted down, now.

Mar 19 2019, 8:46 PM · Installing & Upgrading, Guides, Infrastructure
epriestley closed T13264: Maybe stack multiple breadcrumb sequences? as Wontfix.

Probably a bad idea but maybe I'll revisit this at some point.

Mar 19 2019, 8:45 PM · Design
epriestley closed T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery" as Resolved.

I believe this is now resolved. See D20291 for technical details on the main issue and T13266 for a followup.

Mar 19 2019, 8:45 PM · Diffusion
epriestley committed rPb90e02bec287: Select Ferret fulltext columns in results so fulltext queries work under UNION (authored by epriestley).
Select Ferret fulltext columns in results so fulltext queries work under UNION
Mar 19 2019, 8:22 PM
epriestley closed D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION.
Mar 19 2019, 8:22 PM
epriestley committed rPa8ba8217d84f: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query (authored by epriestley).
Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query
Mar 19 2019, 8:20 PM
epriestley closed D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
Mar 19 2019, 8:20 PM
epriestley updated the diff for D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query.
  • Also skip these columns in "WHERE" on the second page and beyond.
Mar 19 2019, 8:16 PM
epriestley committed rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a… (authored by epriestley).
Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Mar 19 2019, 8:04 PM
epriestley closed D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer.
Mar 19 2019, 8:04 PM
epriestley committed rP18b444e427b0: When queries overheat, raise an exception (authored by epriestley).
When queries overheat, raise an exception
Mar 19 2019, 8:03 PM
epriestley closed D20294: When queries overheat, raise an exception.
Mar 19 2019, 8:03 PM
epriestley committed rP8449c1793ace: Convert complex query subclasses to use internal cursors (authored by epriestley).
Convert complex query subclasses to use internal cursors
Mar 19 2019, 8:02 PM
epriestley closed D20293: Convert complex query subclasses to use internal cursors.
Mar 19 2019, 8:02 PM
epriestley committed rPd4847c3eeb78: Convert simple query subclasses to use internal cursors (authored by epriestley).
Convert simple query subclasses to use internal cursors
Mar 19 2019, 8:00 PM
epriestley closed D20292: Convert simple query subclasses to use internal cursors.
Mar 19 2019, 8:00 PM
epriestley committed rP1b0ef4391032: Separate internal and external Query Cursors more cleanly, to fix pagination… (authored by epriestley).
Separate internal and external Query Cursors more cleanly, to fix pagination…
Mar 19 2019, 8:00 PM