Differential D20312

Don't show a "Manage" button in Legalpad if the user is signing a TOS document
ClosedPublic
Actions

Authored by epriestley on Mar 22 2019, 4:36 PM.

Details

Reviewers

Commits

rPb081053e2694: Don't show a "Manage" button in Legalpad if the user is signing a TOS document

Summary

When a TOS-like Legalpad document is marked "Require this document to use Phabricator", the login prompt shows a "Manage" button, but that button doesn't work.

When we're presenting a document as a session gate, don't show "Manage".

Test Plan

Viewed a required document during a session gate (no "Manage" button) and normally (saw "Manage" button).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2019, 4:36 PM

Harbormaster completed remote builds in B22330: Diff 48466.Mar 22 2019, 4:38 PM

epriestley requested review of this revision.Mar 22 2019, 4:38 PM

amckinley accepted this revision.Mar 25 2019, 6:05 PM

This revision is now accepted and ready to land.Mar 25 2019, 6:05 PM

Closed by commit rPb081053e2694: Don't show a "Manage" button in Legalpad if the user is signing a TOS document (authored by epriestley). · Explain WhyMar 25 2019, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

1 line

legalpad/

controller/

LegalpadDocumentSignController.php

22 lines

Diff 48485

View Options

src/applications/base/controller/PhabricatorController.php