HomePhabricator

Fix transaction queries failing on "withIDs()" after clicking "Show Older"

Description

Fix transaction queries failing on "withIDs()" after clicking "Show Older"

Summary:
See https://discourse.phabricator-community.org/t/unhandled-exception-on-show-older-changes/2545/.

Before T13266, this query got away without having real paging because it used simple ID paging only and results are never actually hidden (today, you can always see all transactions on an object).

Provide withIDs() so the new, slightly stricter paging works.

Test Plan: On an object with "Show Older" in the transaction record, clicked the link. Before: exception in paging code (see Discourse link above). After: transactions loaded cleanly.

Reviewers: amckinley, avivey

Reviewed By: avivey

Differential Revision: https://secure.phabricator.com/D20317

Details

Provenance
epriestleyAuthored on Mar 24 2019, 2:45 PM
epriestleyPushed on Mar 24 2019, 7:25 PM
Reviewer
avivey
Differential Revision
D20317: Fix transaction queries failing on "withIDs()" after clicking "Show Older"
Parents
rPf0ae75c9916a: Fix an issue with "nextPage()" on worker trigger queries
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22341
Build 30568: Run Core Tests