Page MenuHomePhabricator

Make notifications visually clearer, like Feed
ClosedPublic

Authored by epriestley on Mar 22 2019, 4:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 6:52 PM
Unknown Object (File)
Wed, Apr 3, 6:52 PM
Unknown Object (File)
Wed, Apr 3, 6:52 PM
Unknown Object (File)
Wed, Apr 3, 12:54 AM
Unknown Object (File)
Mon, Apr 1, 1:02 PM
Unknown Object (File)
Sat, Mar 30, 10:19 PM
Unknown Object (File)
Fri, Mar 29, 8:12 AM
Unknown Object (File)
Mar 21 2024, 1:25 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T166358. The notifications menu is missing some CSS to color and style values in stories like "renamed task from X to Y".

Test Plan

Before:

Screen Shot 2019-03-22 at 9.12.05 AM.png (100×409 px, 10 KB)

After:

Screen Shot 2019-03-22 at 9.11.44 AM.png (92×402 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

While you're poking at this, I've always wished the link to /notification was called out visually a little more clearly. I always click the bell, look at the bottom of the list of notifications for a "see all" link, and then look back to the top, and then remember that the "Notifications" text is a clickable link.

This revision is now accepted and ready to land.Mar 25 2019, 6:02 PM

Yeah, I don't like the use of non-underlined, non-button links in the UI either. Let me see if I can fix this one, at least...

  • Give the "notifications" link a more standard link color, at least.

I think this could probably be improved more since it's still not as explicit as I'd like, but it's at least less confusing now.

This revision was automatically updated to reflect the committed changes.