Differential D20319

Correct use of the paging API in Phame
ClosedPublic
Actions

Authored by epriestley on Mar 25 2019, 2:28 PM.

Tags

None

Referenced Files

	F18778115: D20319.id.diff
	Sat, Oct 11, 8:09 AM

	F18751167: D20319.id48474.diff
	Sat, Oct 4, 9:56 AM

	F18737256: D20319.id.diff
	Wed, Oct 1, 9:43 AM

	F18725610: D20319.diff
	Tue, Sep 30, 5:30 AM

	F18614040: D20319.id48481.diff
	Sep 14 2025, 11:59 AM

	F18608780: D20319.id48481.diff
	Sep 14 2025, 1:58 AM

	F18596575: D20319.diff
	Sep 13 2025, 1:02 AM

	F18584718: D20319.id48481.diff
	Sep 11 2025, 1:26 PM

View All Files

Subscribers

nicolast

Details

Reviewers

amckinley

Maniphest Tasks

T13266: Upgrading: Minor Changes to Query Paging / Cursors
T13263: Plans: 2019 Week 11-15 Bonus Content

Commits

rPd3df0a49f92a: (stable) Correct use of the paging API in Phame
rPc3563ca15608: Correct use of the paging API in Phame

Summary

Ref T13266. This callsite is using the older API; swap it to use pagers.

Test Plan

Viewed a Phame blog post with siblings, saw the previous/next posts linked.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 25 2019, 2:28 PM

epriestley edited the summary of this revision. (Show Details)Mar 25 2019, 2:30 PM

epriestley added a task: T13266: Upgrading: Minor Changes to Query Paging / Cursors.

Harbormaster completed remote builds in B22344: Diff 48474.Mar 25 2019, 2:30 PM

epriestley requested review of this revision.Mar 25 2019, 2:30 PM

nicolast added a subscriber: nicolast.Mar 25 2019, 4:46 PM

amckinley accepted this revision.Mar 25 2019, 5:35 PM

This revision is now accepted and ready to land.Mar 25 2019, 5:35 PM

Closed by commit rPc3563ca15608: Correct use of the paging API in Phame (authored by epriestley). · Explain WhyMar 25 2019, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

post/

PhamePostViewController.php

15 lines

Diff 48481

View Options

src/applications/phame/controller/post/PhamePostViewController.php

Correct use of the paging API in PhameClosedPublicActions