Page MenuHomePhabricator

Generalize Legalpad validation logic for "Require Signature"
ClosedPublic

Authored by epriestley on Mar 22 2019, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 12:46 PM
Unknown Object (File)
Wed, Apr 3, 6:53 PM
Unknown Object (File)
Wed, Apr 3, 6:53 PM
Unknown Object (File)
Wed, Apr 3, 6:52 PM
Unknown Object (File)
Wed, Apr 3, 1:52 PM
Unknown Object (File)
Sat, Mar 30, 7:49 AM
Unknown Object (File)
Tue, Mar 26, 10:31 AM
Unknown Object (File)
Jan 28 2024, 6:23 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T208254.

I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code.

Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value.

Test Plan

Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required.

Couldn't reproduce the original issue, but this version is generally more correct/robust.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable