Page MenuHomePhabricator

Generalize Legalpad validation logic for "Require Signature"
ClosedPublic

Authored by epriestley on Mar 22 2019, 4:27 PM.
Tags
None
Referenced Files
F18842755: D20311.diff
Tue, Oct 28, 6:16 PM
F18775258: D20311.id.diff
Fri, Oct 10, 6:27 PM
F18773307: D20311.id48484.diff
Thu, Oct 9, 8:56 AM
F18755995: D20311.diff
Oct 5 2025, 8:35 AM
F18733945: D20311.id.diff
Sep 30 2025, 10:44 PM
F18652888: D20311.id48465.diff
Sep 21 2025, 10:01 AM
F18567092: D20311.diff
Sep 9 2025, 3:30 PM
F18518399: D20311.diff
Sep 5 2025, 3:13 PM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T208254.

I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code.

Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value.

Test Plan

Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required.

Couldn't reproduce the original issue, but this version is generally more correct/robust.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable