Page MenuHomePhabricator

Generalize Legalpad validation logic for "Require Signature"
ClosedPublic

Authored by epriestley on Mar 22 2019, 4:27 PM.
Tags
None
Referenced Files
F18100419: D20311.diff
Sat, Aug 9, 11:53 AM
F18083771: D20311.id48484.diff
Tue, Aug 5, 11:21 AM
F18049586: D20311.id.diff
Sun, Aug 3, 4:40 PM
F18011837: D20311.diff
Aug 2 2025, 4:26 PM
F17712005: D20311.diff
Jul 17 2025, 9:21 AM
Unknown Object (File)
Jun 15 2025, 8:41 PM
Unknown Object (File)
Jun 14 2025, 2:51 AM
Unknown Object (File)
Jun 14 2025, 2:49 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T208254.

I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code.

Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value.

Test Plan

Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required.

Couldn't reproduce the original issue, but this version is generally more correct/robust.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable