Paths

Table of Contentst

Differential D20309

When a repository is inactive, mark its handle as "closed"
ClosedPublic
Actions

Authored by epriestley on Mar 22 2019, 4:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 8:04 PM

	Unknown Object (File)
	Fri, Feb 14, 8:04 PM

	Unknown Object (File)
	Fri, Feb 14, 8:04 PM

	Unknown Object (File)
	Fri, Feb 14, 8:04 PM

	Unknown Object (File)
	Sun, Feb 9, 7:27 AM

	Unknown Object (File)
	Sun, Feb 9, 7:27 AM

	Unknown Object (File)
	Sun, Feb 9, 7:27 AM

	Unknown Object (File)
	Sun, Feb 9, 7:27 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPe15b3dd3c610: When a repository is inactive, mark its handle as "closed"

Summary

See downstream https://phabricator.wikimedia.org/T182232. We currently don't mark repository handles as closed.

Test Plan

Mentioned two repositories with R1 (active) and R2 (inactive). After patch, saw R2 visually indicated as closed/inactive.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2019, 4:07 PM

Harbormaster completed remote builds in B22327: Diff 48463.Mar 22 2019, 4:09 PM

epriestley requested review of this revision.Mar 22 2019, 4:09 PM

amckinley accepted this revision.Mar 25 2019, 5:58 PM

This revision is now accepted and ready to land.Mar 25 2019, 5:58 PM

Closed by commit rPe15b3dd3c610: When a repository is inactive, mark its handle as "closed" (authored by epriestley). · Explain WhyMar 25 2019, 6:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

phid/

PhabricatorRepositoryRepositoryPHIDType.php

4 lines

Diff 48483

View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

When a repository is inactive, mark its handle as "closed"ClosedPublicActions