Page MenuHomePhabricator
Differential D20295

Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer
ClosedPublic
Actions

Authored by epriestley on Mar 18 2019, 9:52 PM.
Tags
None
Referenced Files
F18808030: D20295.diff
Sun, Oct 19, 4:44 AM
F18757443: D20295.id.diff
Sun, Oct 5, 5:28 PM
F18754538: D20295.diff
Sat, Oct 4, 11:23 PM
F18733940: D20295.id.diff
Tue, Sep 30, 10:44 PM
F18705545: D20295.id48437.diff
Sun, Sep 28, 11:49 AM
F18699025: D20295.id.diff
Sat, Sep 27, 12:14 PM
F18639552: D20295.diff
Sep 17 2025, 2:08 PM
F18541977: D20295.id48437.diff
Sep 7 2025, 10:04 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery"
Commits
rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Summary

Ref T13259. Currently, visiting a page that executes a query with an invalid cursor raises a bare exception that escapes to top level.

Catch this a little sooner and tailor the page a bit.

Test Plan

Visited /maniphest/?after=335234234223, saw a nicer exception page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48449

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/infrastructure/query/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorInvalidQueryCursorException.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility