Page MenuHomePhabricator
Differential D20295

Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer
ClosedPublic
Actions

Authored by epriestley on Mar 18 2019, 9:52 PM.
Tags
None
Referenced Files
F19472559: D20295.diff
Wed, Jan 7, 9:46 AM
F19082962: D20295.id48449.diff
Dec 2 2025, 12:28 PM
F19078223: D20295.id.diff
Dec 1 2025, 5:27 PM
F19072704: D20295.diff
Nov 30 2025, 11:22 PM
F18989471: D20295.diff
Nov 18 2025, 2:00 PM
F18985081: D20295.id48437.diff
Nov 17 2025, 12:52 PM
F18940702: D20295.diff
Nov 11 2025, 8:54 AM
F18903793: D20295.id48449.diff
Nov 8 2025, 6:19 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery"
Commits
rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Summary

Ref T13259. Currently, visiting a page that executes a query with an invalid cursor raises a bare exception that escapes to top level.

Catch this a little sooner and tailor the page a bit.

Test Plan

Visited /maniphest/?after=335234234223, saw a nicer exception page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48449

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/infrastructure/query/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorInvalidQueryCursorException.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility