Page MenuHomePhabricator
Differential D20317

Fix transaction queries failing on "withIDs()" after clicking "Show Older"
ClosedPublic
Actions

Authored by epriestley on Mar 24 2019, 2:52 PM.
Tags
None
Referenced Files
F13051829: D20317.diff
Fri, Apr 19, 4:55 AM
Unknown Object (File)
Sun, Apr 7, 3:32 PM
Unknown Object (File)
Mon, Apr 1, 5:24 PM
Unknown Object (File)
Mon, Apr 1, 5:24 PM
Unknown Object (File)
Mon, Apr 1, 5:24 PM
Unknown Object (File)
Mon, Apr 1, 5:24 PM
Unknown Object (File)
Sat, Mar 23, 11:29 PM
Unknown Object (File)
Mar 17 2024, 5:07 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Commits
rPe51381e2d6fa: (stable) Fix transaction queries failing on "withIDs()" after clicking "Show…
rPb82557073492: Fix transaction queries failing on "withIDs()" after clicking "Show Older"
Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-show-older-changes/2545/.

Before T13266, this query got away without having real paging because it used simple ID paging only and results are never actually hidden (today, you can always see all transactions on an object).

Provide withIDs() so the new, slightly stricter paging works.

Test Plan

On an object with "Show Older" in the transaction record, clicked the link. Before: exception in paging code (see Discourse link above). After: transactions loaded cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
query/
13 lines

Diff 48472

View Options

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...
Phabricator · Built by Phacility