Page MenuHomePhabricator
Feed All Stories

Aug 24 2016

epriestley closed T7492: Documentation for Paste as Wontfix.

No one actually seems confused by Paste. Obviously documentation "should" exist, but probably not worth keeping this task around since it has just been idle for more than a year. I suspect we'll write it as soon as someone runs into a problem that needs to be documented.

Aug 24 2016, 11:54 PM · Documentation, Paste
epriestley closed T7476: Add function_exists() guards to play nice together with illuminate/support (for working with eloquent, the laravel database layer) as Wontfix.

We haven't seen more interest in this in a long time, and I don't currently plan to make compatibility-focused changes to the stack.

Aug 24 2016, 11:53 PM
epriestley merged T7468: No way to disable web notifications for token awards into T10448: Modularize mail tags.
Aug 24 2016, 11:51 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T7468: No way to disable web notifications for token awards into T10448: Modularize mail tags.
Aug 24 2016, 11:51 PM · Tokens
epriestley added a comment to T7468: No way to disable web notifications for token awards.

I'm going to merge this into T10448, which discusses limitations and improvements to the mail tags system. This is an example of a cross-cutting tag ("No Application/System Settings") that isn't handled gracefully by the current system, but correcting this and other similar issues is a goal of future work.

Aug 24 2016, 11:51 PM · Tokens
epriestley merged T7431: Redesign Welcome Screen for Admins into T11132: New Phabricator NUX.
Aug 24 2016, 11:47 PM · Design, Phacility, NUX
epriestley merged task T7431: Redesign Welcome Screen for Admins into T11132: New Phabricator NUX.
Aug 24 2016, 11:47 PM · Setup
epriestley added a comment to T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..

T7385 is probably also approximately this.

Aug 24 2016, 11:45 PM · Restricted Project, Arcanist, Bug Report
epriestley merged T7385: arc feature D123 fails with ERR-INVALID-SESSION into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:45 PM · Restricted Project, Arcanist, Bug Report
epriestley merged task T7385: arc feature D123 fails with ERR-INVALID-SESSION into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:45 PM · Arcanist
epriestley added a comment to T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.

Commandeer fires Herald rules so stuff like "Require Legalpad Signature" or "Add Reviewers: that intern's wrangler" work.

Aug 24 2016, 11:44 PM · Bug Report
epriestley added a comment to T7301: XHPAST application is not optimized for mobile.

The first page I found on the internet claims the iPhone 7 will be 1920x1080, so my strategy looks like it's paying off!

Aug 24 2016, 11:40 PM · XHPAST, Mobile
epriestley closed T7296: Allow config options to be bound to applications as Wontfix.

I think most of these are just moving into Application configuration over time, which tends to be a bit easier to use. I expect to just continue that trend in the future and this probably isn't worth building separately. I can't recall too much other confusion, and most of these are called <appname>.stuff anyway, which is fairly not-misleading.

Aug 24 2016, 11:39 PM · Restricted Project, Applications
epriestley closed T7286: Re-evaluate whether passing GET data in the body is a good idea as Wontfix.

This doesn't seem to be doing anything bad in practice. I think you can put the data in the URI if you want too and it works fine. Not clear that this is wrong/invalid enough to completely prevent it, and hasn't moved forward in a year and a half or so.

Aug 24 2016, 11:36 PM · libphutil
epriestley closed T7134: Make CDN resource population more robust in the Phacility cluster as Resolved.

I think this was effectively resolved by D15775, which improved behavior for multiple cluster frontends.

Aug 24 2016, 11:32 PM · Phacility
epriestley added a comment to T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..

T7074 may not be this, exactly, but they're close enough for government work.

Aug 24 2016, 11:29 PM · Restricted Project, Arcanist, Bug Report
epriestley merged T7074: `arc patch Dx` shouldn't ask for authentication if Dx is public into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:28 PM · Restricted Project, Arcanist, Bug Report
epriestley merged task T7074: `arc patch Dx` shouldn't ask for authentication if Dx is public into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:28 PM · Arcanist
epriestley added a comment to T6996: Write an `--output <file>` mode for `storage dump` which can gzip.

This seems to be working, I think the last step is replacing the original call in the backup workflow.

Aug 24 2016, 11:28 PM · Infrastructure, Phacility
venky updated the task description for T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.
Aug 24 2016, 11:20 PM · Bug Report
venky created T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.
Aug 24 2016, 11:19 PM · Bug Report
epriestley closed T6853: "Open Revisions Affecting These Files" should weight severity of changes as Wontfix.

We made this a little smarter and a little less prominent (on a non-default tab) and I feel like it's generally in a more reasonable place now. I don't currently expect to make it significantly more complex, and none of the rules proposed here feel like simple, unambiguous improvements to me.

Aug 24 2016, 11:18 PM · Differential
epriestley moved T6832: File/folder properties overwritten during patching from Backlog to arc patch on the Arcanist board.
Aug 24 2016, 11:16 PM · Subversion, Arcanist
epriestley moved T8937: Unclear exception when patching non-existant revision from Backlog to arc patch on the Arcanist board.
Aug 24 2016, 11:16 PM · Arcanist
epriestley moved T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error. from Backlog to arc patch on the Arcanist board.
Aug 24 2016, 11:16 PM · Restricted Project, Arcanist, Bug Report
epriestley closed T6752: Improve functionality of rebasing commits with references in commit message as Wontfix.

We haven't seen other requests in this vein, exactly, in about two years, and we generally don't expect users to rewrite published commits as a routine workflow.

Aug 24 2016, 11:14 PM · Transactions, Diffusion
epriestley added a comment to T6524: Support "request is from IP / subnet" policy rule.

T6706 was the IP-address specific task.

Aug 24 2016, 11:11 PM · Policy
epriestley closed T6524: Support "request is from IP / subnet" policy rule as Wontfix.

We haven't seen other requests for this in nearly two years, and it can likely be implemented as an extension, except possibly for the weird cases mentioned above.

Aug 24 2016, 11:07 PM · Policy
• sshannin closed Q444: Associate old commits with new phabricator user as resolved.
Aug 24 2016, 10:49 PM · Diffusion
• sshannin added Q444: Associate old commits with new phabricator user (Answer 442).
Aug 24 2016, 10:48 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

I have read https://secure.phabricator.com/phame/post/view/766/write_review_merge_publish_phabricator_review_workflow/ , and it briefly addresses this:

Aug 24 2016, 10:32 PM
chad updated subscribers of Q472: What is Differential's position on collaborative branches? (Answer 441).

Oh, yeah, maybe need @avivey or @epriestley for those questions. Over my pay grade.

Aug 24 2016, 10:21 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Yes, that works if you decide to collaborate ahead of time. If you decide to "stack" on top of a revision under review, you have to either

Aug 24 2016, 10:20 PM
jcox added a revision to T10951: Search shows document types corresponding to disabled apps: Unknown Object (Differential Revision).
Aug 24 2016, 10:11 PM · Contributor Onboarding, Search, Bug Report
chad added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Personally, I think it's maybe easier to do review along the way, but you can go the other route where you just both git push to the remote branch, then review run arc diff when you want to merge it into master.

Aug 24 2016, 10:08 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Hmm, but that's not quite the same thing as what I'm asking (I think) -- in my scenario a pair of authors are adding commits to a branch off master (imagine it's a refactor and we're fixing different tests), and the stack of commits is reviewed in one PR. I know I can do this today by just creating a remote branch, collaborating with someone on it, and doing no code review until all the commits land (at which time one of us creates the Differential revision).

Aug 24 2016, 10:06 PM
chad added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

I can't easily find an example, think its been about 18 months since we last did a feature branch.

Aug 24 2016, 10:05 PM
chad added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

It's sort of like:

Aug 24 2016, 10:00 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Could you point me at an example revision to see how this looks?

Aug 24 2016, 9:55 PM
chad added Q472: What is Differential's position on collaborative branches? (Answer 441).
Aug 24 2016, 9:53 PM
jcox added a revision to T10951: Search shows document types corresponding to disabled apps: Unknown Object (Differential Revision).
Aug 24 2016, 9:44 PM · Contributor Onboarding, Search, Bug Report
venky awarded T11518: Make arc feature much more fancy and fun a Like token.
Aug 24 2016, 9:31 PM · Restricted Project, Feature Request
venky updated the question details for Q472: What is Differential's position on collaborative branches?.
Aug 24 2016, 9:29 PM · Differential
venky updated Q472: What is Differential's position on collaborative branches? from to What is Differential's position on collaborative branches?.
Aug 24 2016, 9:29 PM · Differential
jcox added a revision to T10999: Expand MFA checks to all email operations: Unknown Object (Differential Revision).
Aug 24 2016, 9:09 PM · Contributor Onboarding, Security
jcox closed T11508: Create a blacklist of terms that chatbots should ignore as Resolved by committing Restricted Diffusion Commit.
Aug 24 2016, 8:08 PM · Contributor Onboarding, Feature Request
epriestley closed T6486: Pending Differential Revisions isn't filtered by branch as Wontfix.

We haven't seen other users run into difficulty with this in the last couple of years, so I don't currently plan to change it.

Aug 24 2016, 7:52 PM · Diffusion
jcox added a revision to T11508: Create a blacklist of terms that chatbots should ignore: Unknown Object (Differential Revision).
Aug 24 2016, 7:50 PM · Contributor Onboarding, Feature Request
epriestley closed T6330: Add filter for "Unverified" users in People module as Wontfix.

This was filed a while ago, but it's not clear to me why this is useful -- no obvious reason to want to do this springs to mind.

Aug 24 2016, 7:30 PM · People
epriestley closed T5704: Print where we're reading configuration from on Phabricator script startup with --trace as Wontfix.

No clue what this was, haven't had issues recently. I think config may have become simpler in the last couple years.

Aug 24 2016, 7:14 PM · Setup
epriestley merged task T5312: Error raised when updating a revision which has non-permitted reviewers because of policy constraints into T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").
Aug 24 2016, 7:02 PM · Differential
epriestley merged T5312: Error raised when updating a revision which has non-permitted reviewers because of policy constraints into T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").
Aug 24 2016, 7:02 PM · Bug Report
epriestley closed T5327: Provide a `./bin/lookup` script as Wontfix.

Although I don't think this is necessarily a bad idea, I haven't seen too much of a need for this. Some alternatives:

Aug 24 2016, 7:01 PM
avivey renamed T11521: Request Review action should clear "accepted older" status from [Differential] "Ready to review" list doesn't include NEEDS_REVIEW revisions with reviewer status ACCEPTED_OLDER to Request Review action should clear "accepted older" status.
Aug 24 2016, 5:00 PM · Restricted Project, Differential, Bug Report
• glz updated the question details for Q471: git clone/push using HTTP error.
Aug 24 2016, 4:47 PM
• glz updated Q471: git clone/push using HTTP error from to git clone/push using HTTP error.
Aug 24 2016, 4:44 PM
epriestley closed T11525: phutil_utf8ize() does not normalize overlong forms of 3-byte and 4-byte characters, but json_encode() refuses to encode them as Resolved by committing Restricted Diffusion Commit.
Aug 24 2016, 4:31 PM
jsixface awarded T5051: Burn down charts for Milestones a Mountain of Wealth token.
Aug 24 2016, 4:13 PM · Restricted Project, Wikimedia, Projects
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 4:02 PM · Diffusion
epriestley added a revision to T11525: phutil_utf8ize() does not normalize overlong forms of 3-byte and 4-byte characters, but json_encode() refuses to encode them: Unknown Object (Differential Revision).
Aug 24 2016, 3:53 PM
Grimeh updated Q470: Best way to make use of Phabricator in multi-site company? from Best way to have multi-site Phabricator instance to Best way to make use of Phabricator in multi-site company?.
Aug 24 2016, 3:33 PM · Clusters, Arcanist, Differential, Diffusion
Grimeh updated Q470: Best way to make use of Phabricator in multi-site company? from to Best way to have multi-site Phabricator instance.
Aug 24 2016, 3:32 PM · Clusters, Arcanist, Differential, Diffusion
jcox closed T9982: Eventually, drop the conduit_connectionlog table as Resolved by committing Restricted Diffusion Commit.
Aug 24 2016, 3:04 PM · Contributor Onboarding, Restricted Project, Conduit
jcox closed T9982: Eventually, drop the conduit_connectionlog table, a subtask of T9980: Give administrators better tools for managing Conduit API changes, as Resolved.
Aug 24 2016, 3:04 PM · Conduit
jcox added a revision to T9690: Remove calls to methods deprecated by newPage(): Unknown Object (Differential Revision).
Aug 24 2016, 3:01 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley created T11525: phutil_utf8ize() does not normalize overlong forms of 3-byte and 4-byte characters, but json_encode() refuses to encode them.
Aug 24 2016, 2:33 PM
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 1:28 PM · Diffusion
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 12:59 PM · Diffusion
epriestley added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

Ah, thanks! I think that should be relatively easy to fix.

Aug 24 2016, 12:43 PM · Restricted Project, Bug Report
de_jean_7777 added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

This happens for everyone here in the company on windows chrome with the HRV (Croatian) layout, where the @ symbol is achieved with the right side alt (ALTGR) + "V". Think that registers ALT + CTRL + V.

Aug 24 2016, 12:37 PM · Restricted Project, Bug Report
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 12:35 PM · Diffusion
aklapper updated subscribers of T5051: Burn down charts for Milestones.
Aug 24 2016, 12:25 PM · Restricted Project, Wikimedia, Projects
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 12:06 PM · Diffusion
epriestley added a comment to T11522: Improve support for guiding users through repository rewrites.

We have an existing repository_badcommit table which is used to mark commits as "bad", where "bad" approximately means "the repository as a whole works, but the VCS tools can not read or should not read this particular commit for whatever reason". This is rare, but can happen when, e.g., third-party tools are used to write into repositories.

Aug 24 2016, 11:33 AM · Diffusion
gokulpd added a comment to T11523: Unhandled Exception ("AphrontSchemaQueryException").

Yes, I have tried to do storage upgrade but it ends up with an error.

Aug 24 2016, 11:32 AM · Bug Report (Needs Information)
epriestley added a comment to T11523: Unhandled Exception ("AphrontSchemaQueryException").

Have you tried following the instructions given in the error message?

Aug 24 2016, 11:13 AM · Bug Report (Needs Information)
epriestley created T11524: Import-time diff generation fails for particular commits in cluster mode.
Aug 24 2016, 11:09 AM · Phacility, Clusters, Daemons, Diffusion
stevex updated subscribers of T5051: Burn down charts for Milestones.
In T5051#156552, @chad wrote:

...
This task will be re-scoped to just being about burn down charts for milestones.

Aug 24 2016, 10:31 AM · Restricted Project, Wikimedia, Projects
gokulpd updated subscribers of T11523: Unhandled Exception ("AphrontSchemaQueryException").
Aug 24 2016, 9:55 AM · Bug Report (Needs Information)
gokulpd created T11523: Unhandled Exception ("AphrontSchemaQueryException").
Aug 24 2016, 9:55 AM · Bug Report (Needs Information)
epriestley created T11522: Improve support for guiding users through repository rewrites.
Aug 24 2016, 1:09 AM · Diffusion
epriestley closed T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks as Resolved.

Re-reading D9115, I think I was never able to understand or reproduce this and it was ultimately mooted anyway.

Aug 24 2016, 12:00 AM · Restricted Project, libphutil

Aug 23 2016

epriestley closed T4909: Rate limit or restrict access to comment removal as Wontfix.

As far as I know, no users have actually gone berserk and deleted all their comments in nearly two years now, so I don't plan to specifically build comment removal rate limiting: this action does not seem particularly more dangerous or abuse-prone in practice than other actions like adding comments, merging tasks, etc. If a user did do this, recovery is likely not very difficult even without limiting.

Aug 23 2016, 10:38 PM · Abuse, Wikimedia
chad added a comment to T11132: New Phabricator NUX.

Though I guess a "fake" dashboard is not as performant as actual dashboards. But equivalent to current hardcoded homepage?

Aug 23 2016, 7:58 PM · Design, Phacility, NUX
chad added a comment to T11132: New Phabricator NUX.

Yeah, I think scope-wise this could get out of hand quickly and consume a month on both design and engineering. I think I can propose something here that will not take your time and maybe 1-2 days of mine.

Aug 23 2016, 7:56 PM · Design, Phacility, NUX
epriestley closed T4782: Provide short revision status summary in Differential query results? as Wontfix.

I built a similar UI as part of D15926, but we declined to actually bring it upstream. It's possible that we may revisit this in the future, or that it may become possible via T418, but I don't currently plan to pursue this.

Aug 23 2016, 7:27 PM · Custom Fields, Differential
epriestley closed T4661: Custom "date" field displays date input in different format than preferences as Resolved.

We now allow you control component order in the date control.

Aug 23 2016, 7:13 PM · User Preferences
epriestley closed T4485: Try to guess when a user copy/pastes a giant block of output from something? as Wontfix.

I haven't come up with any kind of rule for this in the last couple years which feels sufficiently un-magical, even in theory. It hasn't happened all that often recently, either, at least that I can recall.

Aug 23 2016, 7:11 PM · Remarkup
epriestley closed T4445: Diffusion tag cache not updating correctly when tags move? as Resolved.

This is like two years old now, and I'm pretty sure it works now since no one else has reported it and it would likely have come up when clustering was written a few months ago if it was still an issue. If anyone is still seeing issues, please feel free to file a new report with reproduction steps.

Aug 23 2016, 7:08 PM · Diffusion
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

arc cast

Aug 23 2016, 7:04 PM · Celerity
epriestley closed T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls as Resolved.

I think this was effectively resolved by D12773, since using conduit.token should evade the session timeout.

Aug 23 2016, 7:02 PM · Conpherence, Phabot
epriestley added a comment to T3311: Detect or manage optipng versions (-clobber flag).

Sounds like we should write a "Screencastph" app!

Aug 23 2016, 7:01 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

is there a twitch module for bash? can I live stream this excitement?

Aug 23 2016, 7:00 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

how.will.it.end

Aug 23 2016, 6:59 PM · Celerity
epriestley added a comment to T3311: Detect or manage optipng versions (-clobber flag).

rough life :(

Aug 23 2016, 6:56 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

do-dist-upgrade is pushing me to 16.04

Aug 23 2016, 6:54 PM · Celerity
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

welp

Aug 23 2016, 6:53 PM · Celerity
epriestley added a project to T4190: Rebuild remarkup image proxying: Contributor Onboarding.
Aug 23 2016, 6:53 PM · Contributor Onboarding, Remarkup
chad added a comment to T3311: Detect or manage optipng versions (-clobber flag).

I'm on 14.04 and it has 0.6.4 installed. :(

Aug 23 2016, 6:47 PM · Celerity
chad changed the visibility for T3311: Detect or manage optipng versions (-clobber flag).
Aug 23 2016, 6:46 PM · Celerity