Page MenuHomePhabricator

venky (Venky Iyer)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 29 2016, 6:26 AM (205 w, 18 h)
Availability
Available

Recent Activity

Sep 2 2016

venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

:) It's not a very important bug, but isn't it still a bug that the button shows up?

Sep 2 2016, 9:55 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

Got it.

Sep 2 2016, 9:51 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

I was expecting to see exactly the view in your screenshot -- changed files expanded inline, and moved files described as such.

Sep 2 2016, 9:33 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

I wonder why I had a different behavior:

Sep 2 2016, 9:28 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

I suspect that diff.renames has the same behavior from recent versions, just that it is enabled by default.

Sep 2 2016, 9:23 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".
$ git diff HEAD^..HEAD | head
diff --git a/app/client/config/BaseStyles.js b/app-moved/client/config/BaseStyles.js
similarity index 100%
rename from app/client/config/BaseStyles.js
rename to app-moved/client/config/BaseStyles.js
diff --git a/app/client/config/DateTimeFormats.json b/app-moved/client/config/DateTimeFormats.json
similarity index 100%
rename from app/client/config/DateTimeFormats.json
rename to app-moved/client/config/DateTimeFormats.json
diff --git a/app/client/config/categories.json b/app-moved/client/config/categories.json
similarity index 100%
Sep 2 2016, 9:22 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

Wow, that's strange. Is it possible that you have a different setting for diff.renames?

Sep 2 2016, 9:11 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

Yes, I'm not claiming that git can somehow not show actual changes, just that it doesn't show file renames. This is what I was doing:

Sep 2 2016, 9:05 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

I was thinking of what you see when you then do git add, git commit, and git diff HEAD..HEAD^. I might be using the wrong terminology perhaps

Sep 2 2016, 8:51 PM · Feature Request
venky edited projects for T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline", added: Feature Request; removed Bug Report.
Sep 2 2016, 6:32 PM · Feature Request
venky added a comment to T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".

I can make it a feature request. I marked it as a bug because git diff will return something that's pretty small in this scenario.

Sep 2 2016, 6:32 PM · Feature Request
venky added a comment to T11574: Consider making "Page updated, reload" notification more prominent.

We'll take this into consideration and keep an eye open for other feedback,

Sep 2 2016, 6:13 PM · Feature Request
venky updated subscribers of T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".
Sep 2 2016, 5:57 PM · Feature Request
venky created T11578: Moving many files and changing a few leads to "This diff is very large and affects 111 files. You may load each file individually or Show All Files Inline".
Sep 2 2016, 5:57 PM · Feature Request

Sep 1 2016

venky created T11574: Consider making "Page updated, reload" notification more prominent.
Sep 1 2016, 8:33 PM · Feature Request
venky added a comment to T11530: Conduit query for Differential revisions mentioning a project.
In T11530#192966, @chad wrote:

Maybe create a bot user called @shipit to trigger herald? Mentioning users CCs them to the object, but mentioning projects does nothing currently.

Sep 1 2016, 8:29 PM · Herald, Conduit, Differential, Feature Request

Aug 26 2016

venky renamed T11542: Make remarkup checklists interactive from Make markdown checklists interactive to Make remarkup checklists interactive.
Aug 26 2016, 6:50 PM · Remarkup, Feature Request
venky updated the task description for T11542: Make remarkup checklists interactive.
Aug 26 2016, 6:49 PM · Remarkup, Feature Request
venky created T11542: Make remarkup checklists interactive.
Aug 26 2016, 6:47 PM · Remarkup, Feature Request
venky awarded T11540: Write something that is technically a game for Ludum Dare 36 a 100 token.
Aug 26 2016, 6:39 PM

Aug 25 2016

venky added a comment to T11481: Allow customization of forms for Workboards.

A potentially less controversial fix for the 2-step entry issue might be to add a keyboard shortcut that will add a task to the last used column.

Aug 25 2016, 9:06 PM · Workboards, Feature Request
venky added a comment to T11530: Conduit query for Differential revisions mentioning a project.

Herald firing on other things: T10109

Aug 25 2016, 9:48 AM · Herald, Conduit, Differential, Feature Request
venky updated the task description for T11530: Conduit query for Differential revisions mentioning a project.
Aug 25 2016, 9:21 AM · Herald, Conduit, Differential, Feature Request
venky added projects to T11530: Conduit query for Differential revisions mentioning a project: Conduit, Herald.
Aug 25 2016, 9:20 AM · Herald, Conduit, Differential, Feature Request
venky updated the task description for T11530: Conduit query for Differential revisions mentioning a project.
Aug 25 2016, 9:19 AM · Herald, Conduit, Differential, Feature Request
venky renamed T11530: Conduit query for Differential revisions mentioning a project from A way to programmatically determine when a project is mentioned to Conduit query for Differential revisions mentioning a project.
Aug 25 2016, 9:18 AM · Herald, Conduit, Differential, Feature Request
venky created T11530: Conduit query for Differential revisions mentioning a project.
Aug 25 2016, 9:18 AM · Herald, Conduit, Differential, Feature Request
venky added a comment to T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.

Commandeer is a pretty infrequent action so this doesn't matter much, but out of curiosity could I avoid this with a better Herald rule? I guess I can try Changed file content matches regexp '.'.

Aug 25 2016, 12:50 AM · Bug Report

Aug 24 2016

venky updated the task description for T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.
Aug 24 2016, 11:20 PM · Bug Report
venky created T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.
Aug 24 2016, 11:19 PM · Bug Report
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

I have read https://secure.phabricator.com/phame/post/view/766/write_review_merge_publish_phabricator_review_workflow/ , and it briefly addresses this:

Aug 24 2016, 10:32 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Yes, that works if you decide to collaborate ahead of time. If you decide to "stack" on top of a revision under review, you have to either

Aug 24 2016, 10:20 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Hmm, but that's not quite the same thing as what I'm asking (I think) -- in my scenario a pair of authors are adding commits to a branch off master (imagine it's a refactor and we're fixing different tests), and the stack of commits is reviewed in one PR. I know I can do this today by just creating a remote branch, collaborating with someone on it, and doing no code review until all the commits land (at which time one of us creates the Differential revision).

Aug 24 2016, 10:06 PM
venky added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

Could you point me at an example revision to see how this looks?

Aug 24 2016, 9:55 PM
venky awarded T11518: Make arc feature much more fancy and fun a Like token.
Aug 24 2016, 9:31 PM · Restricted Project, Feature Request
venky updated the question details for Q472: What is Differential's position on collaborative branches?.
Aug 24 2016, 9:29 PM · Differential
venky updated Q472: What is Differential's position on collaborative branches? from to What is Differential's position on collaborative branches?.
Aug 24 2016, 9:29 PM · Differential

Aug 16 2016

venky added a comment to T11481: Allow customization of forms for Workboards.

I agree that there *shouldn't* be any extra cost purely owing to having more fields if I'm only editing one and it is default-focused, but I'd argue that having a more complex form will still slow humans down (at least initially).

Aug 16 2016, 11:59 PM · Workboards, Feature Request
venky added a comment to T11481: Allow customization of forms for Workboards.

Is this really "Make Workboards look and feel exactly like Trello"?

Aug 16 2016, 11:42 PM · Workboards, Feature Request
venky added a comment to T11481: Allow customization of forms for Workboards.

More fields means

Aug 16 2016, 11:20 PM · Workboards, Feature Request

Aug 15 2016

venky created T11481: Allow customization of forms for Workboards.
Aug 15 2016, 11:55 PM · Workboards, Feature Request
venky awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Aug 15 2016, 11:36 PM · Workboards (v3), Restricted Project
venky added a comment to T6064: One-Click Add Task on Workboard Columns.

Starting to try out Workboards (we're coming from Trello), and I felt the absence of this feature as well.

Aug 15 2016, 11:36 PM · Restricted Project, Workboards

Aug 14 2016

venky added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

Awesome! I appreciate the quick fixes!

Aug 14 2016, 10:07 PM · Harbormaster, Conduit, Bug Report
venky added a comment to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.

slightly related: there's some confusing naming in the result for harbormaster.querybuildables:

Aug 14 2016, 8:46 AM · Harbormaster, Conduit, Bug Report
venky added projects to T11473: harbormaster.build.search doesn't appear to constrain on 'buildables': Conduit, Harbormaster.
Aug 14 2016, 8:41 AM · Harbormaster, Conduit, Bug Report
venky created T11473: harbormaster.build.search doesn't appear to constrain on 'buildables'.
Aug 14 2016, 8:41 AM · Harbormaster, Conduit, Bug Report

Aug 12 2016

venky added a comment to T11411: Commits to github branch close Differential revision.

This is resolved on my end.

Aug 12 2016, 2:50 AM · Documentation, Diffusion
venky removed a project from T11467: Deleting a mailing list user on hosted instance: Phacility.
Aug 12 2016, 2:38 AM · Bug Report
venky added a comment to T11467: Deleting a mailing list user on hosted instance.

Please close - I figured out how to change the username. Not sure why I missed it the first time :(

Aug 12 2016, 2:37 AM · Bug Report
venky created T11467: Deleting a mailing list user on hosted instance.
Aug 12 2016, 2:21 AM · Bug Report

Aug 11 2016

venky updated the task description for T11466: Build status on Differential search results.
Aug 11 2016, 9:05 PM · Differential, Feature Request
venky added a comment to T11466: Build status on Differential search results.

Here's github's version of this, as an example.

Aug 11 2016, 9:04 PM · Differential, Feature Request
venky created T11466: Build status on Differential search results.
Aug 11 2016, 9:03 PM · Differential, Feature Request
venky added a comment to T11452: feed.http-hooks on hosted instance.

@epriestley - I currently don't have the permissions to edit feed.http-hooks -- it claims I don't have permissions to manage the "finxpc.phacility.com" instance, however I'm apparently an admin on it. We (Danny, the person who set up the instance and I) have also been unable to figure out how to grant me any different permissions - could you please give us a nudge in the right direction? Danny also appears to be an admin, same as me, but has permissions to edit that variable.

Aug 11 2016, 5:17 PM · Phacility, Feature Request
venky created T11463: Search should probably do some minimal stemming.
Aug 11 2016, 4:58 PM · Feature Request
venky awarded T10612: Editing a panel causes it to duplicate in dashboard a Like token.
Aug 11 2016, 4:25 PM · Dashboards (v2), Bug Report
venky renamed T11459: Dashboards: Text panel duplicated in 2-column layout from Text panel duplicated in 2-column layout to Dashboards: Text panel duplicated in 2-column layout.
Aug 11 2016, 9:18 AM · Dashboards, Bug Report
venky added a comment to T11459: Dashboards: Text panel duplicated in 2-column layout.

In fact, this also happens with other panels. Basically the top right panel will always be duplicated to bottom left.

Aug 11 2016, 9:08 AM · Dashboards, Bug Report
venky created T11459: Dashboards: Text panel duplicated in 2-column layout.
Aug 11 2016, 9:05 AM · Dashboards, Bug Report

Aug 10 2016

venky added a comment to T11423: arcanist segmentation faults.

I haven't seen more segfaults since I switched.

Aug 10 2016, 8:49 PM · Bug Report (Needs Information)

Aug 9 2016

venky added a comment to T11452: feed.http-hooks on hosted instance.

Thanks for the pointers, I'll try that.

Aug 9 2016, 7:41 PM · Phacility, Feature Request
venky added a comment to T11452: feed.http-hooks on hosted instance.

I don't want to distract this too much with the "automatic land on accept without author intervention" case. Is there a way to achieve the less controversial "author-triggered land without going to the CLI" case?

Aug 9 2016, 6:57 PM · Phacility, Feature Request
venky added a comment to T11452: feed.http-hooks on hosted instance.

In the common case, I'm not arguing against that principle -- "closing a revision" in my example above is a trigger initiated by a human. I'm just not requiring them to switch branches and type arc land. T182 supports this thinking, it seems.

Aug 9 2016, 6:55 PM · Phacility, Feature Request
venky added a comment to T11452: feed.http-hooks on hosted instance.

Are you manually closing the revision as a signal that the revision is "ready to be landed"?`

Yes, that's what I was aiming to achieve. Is there a better way to do this?

Aug 9 2016, 6:03 PM · Phacility, Feature Request
venky added a comment to T11452: feed.http-hooks on hosted instance.

It perhaps does, I'm still trying to figure all of this out. So a harbormaster http request would notify the bot to deploy, and a herald rule would trigger that request. If we wanted to deploy multiple revisions in one push, we'd just buffer the http requests on the deploybot's end.

Aug 9 2016, 5:48 PM · Phacility, Feature Request
venky added a comment to T11450: Distinguish between issue and non-issue inline comments.

I will add my vote for a small subset/version of this, ie. hoist inline comments and their "done" state into an easily perusable checklist.

Aug 9 2016, 5:15 PM · Inline Comments, Restricted Project, Feature Request
venky added a comment to T11411: Commits to github branch close Differential revision.

The other thing that was confusing was that "Config" didn't actually have all the settings -- some settings are in Config, some user settings are in my "profile", some other settings are in individual apps. It would help to consolidate these into one directory.

Aug 9 2016, 5:12 PM · Documentation, Diffusion
venky created T11452: feed.http-hooks on hosted instance.
Aug 9 2016, 5:10 PM · Phacility, Feature Request

Aug 4 2016

venky created T11425: Add "Locate File" functionality to branch view in Diffusion.
Aug 4 2016, 1:53 AM · Feature Request
venky created T11424: Differential inline comments (their positions) are misleading after new diff.
Aug 4 2016, 12:55 AM · Bug Report

Aug 3 2016

venky added a comment to T11423: arcanist segmentation faults.
$ php --version
PHP 7.1.0beta1 (cli) (built: Jul 25 2016 13:58:06) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.1.0-dev, Copyright (c) 1998-2016 Zend Technologies

That might explain it (not sure how I got on the beta, wasn't aiming to). I've switched to the 7.0 version, will see if that fixes it.

Aug 3 2016, 10:45 PM · Bug Report (Needs Information)
venky created T11423: arcanist segmentation faults.
Aug 3 2016, 10:11 PM · Bug Report (Needs Information)

Aug 1 2016

venky added a comment to T11411: Commits to github branch close Differential revision.

Maybe link it in the "Explain why" dialog?

Aug 1 2016, 6:04 PM · Documentation, Diffusion
venky added a comment to T11411: Commits to github branch close Differential revision.

Ah, sweet. Thank you!

Aug 1 2016, 6:02 PM · Documentation, Diffusion
venky created T11411: Commits to github branch close Differential revision.
Aug 1 2016, 5:09 PM · Documentation, Diffusion
venky added a comment to T11397: Overcommit -> arc lint.
Aug 1 2016, 8:00 AM · Feature Request

Jul 30 2016

venky added a comment to T11397: Overcommit -> arc lint.

Not claiming it's better (it seems to do a lot of what arc lint does, minus the ability to amend), just that we already have linting set up through it and have custom linters implemented in that framework.

Jul 30 2016, 1:09 AM · Feature Request

Jul 29 2016

venky created T11397: Overcommit -> arc lint.
Jul 29 2016, 11:13 PM · Feature Request