Page MenuHomePhabricator
Feed All Stories

Aug 23 2016

epriestley closed T3311: Detect or manage optipng versions (-clobber flag) as Wontfix.

This hasn't come up again in three years so I'm just going to assume that everyone is realistically installing 0.7.0 or newer nowadays. Today, optiping strongly recommends upgrading to 0.7.6 or newer to fix some security issues.

Aug 23 2016, 6:42 PM · Celerity
nornagon created T11521: Request Review action should clear "accepted older" status.
Aug 23 2016, 6:41 PM · Restricted Project, Differential, Bug Report
nfirmani created T11520: Arc Lint - Severity configuration behaves differently for different linters.
Aug 23 2016, 6:39 PM · Bug Report
jasonfsmitty added a comment to T11519: Herald unable to email the owners of a package.

Forgot to mention we're running stable week 34.

Aug 23 2016, 6:25 PM · Bug Report
epriestley added a comment to T11519: Herald unable to email the owners of a package.

Let me see if I can reproduce this, but this is probably straightforward to fix -- I suspect some code just didn't get updated when Owners packages became mailable.

Aug 23 2016, 6:25 PM · Bug Report
epriestley awarded T11518: Make arc feature much more fancy and fun a Party Time token.
Aug 23 2016, 6:23 PM · Restricted Project, Feature Request
michaeljs1990 awarded T11518: Make arc feature much more fancy and fun a Dat Boi token.
Aug 23 2016, 6:22 PM · Restricted Project, Feature Request
jasonfsmitty created T11519: Herald unable to email the owners of a package.
Aug 23 2016, 6:19 PM · Bug Report
epriestley closed T2519: Phabricator as Mailing List manager, a subtask of T4267: Support alias accounts, as Wontfix.
Aug 23 2016, 6:09 PM · Restricted Project, FreeBSD
epriestley closed T2519: Phabricator as Mailing List manager as Wontfix.

This a very old task that lacks root problem / use case information that we require for modern feature requests.

Aug 23 2016, 6:09 PM · Conpherence
avivey added a comment to T11518: Make arc feature much more fancy and fun.

Revision.

Aug 23 2016, 6:05 PM · Restricted Project, Feature Request
yelirekim added a comment to T11518: Make arc feature much more fancy and fun.

Basically "is the diff people are reviewing identical to your local branch"

Aug 23 2016, 6:05 PM · Restricted Project, Feature Request
yelirekim added a comment to T11518: Make arc feature much more fancy and fun.

Revision.

Aug 23 2016, 6:04 PM · Restricted Project, Feature Request
avivey added a comment to T11518: Make arc feature much more fancy and fun.

I'd call this thing arc status, because arc feature is "a wrapper on git branch", and flow makes me think of git-flow.

Aug 23 2016, 5:59 PM · Restricted Project, Feature Request
chad added a comment to T11518: Make arc feature much more fancy and fun.

which devs don't? it's the designers, isn't it.

Aug 23 2016, 5:53 PM · Restricted Project, Feature Request
yelirekim created T11518: Make arc feature much more fancy and fun.
Aug 23 2016, 5:52 PM · Restricted Project, Feature Request
epriestley added a comment to T2493: Support `arc land` in stacked commits.

This general issue receives significant discussion in T3875. I don't think we've seen significant adoption of the unusual "stacked-on-the-same-branch" workflow, but similar concerns apply to branches-on-branches at the least.

Aug 23 2016, 5:44 PM · Restricted Project, Arcanist
epriestley added a parent task for T2493: Support `arc land` in stacked commits: T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`.
Aug 23 2016, 5:42 PM · Restricted Project, Arcanist
epriestley added a subtask for T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`: T2493: Support `arc land` in stacked commits.
Aug 23 2016, 5:42 PM · Prioritized, Restricted Project, Arcanist
rayzyar updated the task description for T11517: arc lint missed some error reported from the golint.
Aug 23 2016, 5:42 PM · Bug Report (Needs Information), Arcanist, Lint
rayzyar edited projects for T11517: arc lint missed some error reported from the golint, added: Bug Report; removed Bug Report (Needs Information).
Aug 23 2016, 5:41 PM · Bug Report (Needs Information), Arcanist, Lint
epriestley closed T1621: In Git, clean up local tags that are no longer present in the remote as Resolved.

I believe this was resolved by T6878 or related work. In the modern codebase, we fetch with --prune and explicit refspecs, which is sufficient according to git help fetch:

Aug 23 2016, 5:40 PM · Restricted Project, Diffusion
eadler added a project to T11509: Provide a way to quickly see if all comments on a diff have been marked as "done": Restricted Project.
Aug 23 2016, 4:53 PM · Inline Comments, Differential, Restricted Project, Feature Request
eadler added a project to T11502: Expose raw Git refs in the Diffusion UI, but very subtly: Restricted Project.
Aug 23 2016, 4:52 PM · Restricted Project, Diffusion
eadler added a project to T11511: Give edit forms email addresses: Restricted Project.
Aug 23 2016, 4:50 PM · Restricted Project, Contributor Onboarding, Feature Request
eadler added a project to T11513: Convert the application selector in "pin applications" to a typeahead: Restricted Project.
Aug 23 2016, 4:50 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
rayzyar added a comment to T11517: arc lint missed some error reported from the golint.
In T11517#191349, @chad wrote:

Please follow the instructions in Contributing Bug Reports. This is not a valid report without version information and step by step reproduction information.

Aug 23 2016, 3:20 PM · Bug Report (Needs Information), Arcanist, Lint
rayzyar updated the task description for T11517: arc lint missed some error reported from the golint.
Aug 23 2016, 3:20 PM · Bug Report (Needs Information), Arcanist, Lint
rayzyar updated the task description for T11517: arc lint missed some error reported from the golint.
Aug 23 2016, 3:14 PM · Bug Report (Needs Information), Arcanist, Lint
stevex awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Aug 23 2016, 2:15 PM · Restricted Project, Restricted Project, KDE, Unknown Object (Project), FreeBSD, Wikimedia, Projects
chad edited projects for T11517: arc lint missed some error reported from the golint, added: Bug Report (Needs Information); removed Bug Report.
Aug 23 2016, 1:57 PM · Bug Report (Needs Information), Arcanist, Lint
chad added a comment to T11517: arc lint missed some error reported from the golint.

Please follow the instructions in Contributing Bug Reports. This is not a valid report without version information and step by step reproduction information.

Aug 23 2016, 1:57 PM · Bug Report (Needs Information), Arcanist, Lint
joshuaspence added a member for Contributor Onboarding: joshuaspence.
Aug 23 2016, 12:32 PM
joshuaspence awarded T11480: Stop sending misbehaving user nonsense to the error log a Doubloon token.
Aug 23 2016, 12:26 PM
epriestley closed T11516: Test open as Invalid.
Aug 23 2016, 11:56 AM · Bug Report
maxie added a project to Q468: Create task from emails: Mail.
Aug 23 2016, 11:47 AM · Mail
shpytyack.artem added a comment to T4657: Add a one-click "Close" button to Maniphest.

So for us "Close task" doesn't work anymore, looks like you just have deleted the code which processed the button. Is there any replacement for this I don't know or you have just deleted a nice convenient feature which worked fine for some people like we are?

Aug 23 2016, 9:57 AM · Maniphest
• liub815 added a comment to T10405: Phabricator should generally work properly even if "gd" is not installed.

who can help me?

Aug 23 2016, 9:22 AM · Setup, Restricted Project
rayzyar added projects to T11517: arc lint missed some error reported from the golint: Lint, Arcanist.
Aug 23 2016, 9:08 AM · Bug Report (Needs Information), Arcanist, Lint
rayzyar created T11517: arc lint missed some error reported from the golint.
Aug 23 2016, 9:06 AM · Bug Report (Needs Information), Arcanist, Lint
• liub815 added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

I need help:>>> UNRECOVERABLE FATAL ERROR <<<

Aug 23 2016, 9:05 AM · Bug Report (Needs Information)
• j66166 created T11516: Test open.
Aug 23 2016, 8:26 AM · Bug Report
clemvangelis added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

Note: this is only to log informations and try to reproduce the issue, with other user who see this bug, is it okay if I keep using this ticket ?

Aug 23 2016, 8:21 AM · Bug Report (Needs Information)
sascha-egerer added a comment to T11515: `arc ade` should do something.

I hate commanding arc with these commands. Can we also please add please do a prefix for everything? Like arc please do a diff, arc please do a land

Aug 23 2016, 8:15 AM · Feature Request
epriestley closed T11507: Many Modal workflows don't work ( JS Crash ) as Invalid.

Ah, the project creation issue with gd issue is captured in T10405.

Aug 23 2016, 5:08 AM · Bug Report (Needs Information)
• ramprabhuj added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

@epriestley - I did the same on your setup and can't reproduce!

Aug 23 2016, 4:34 AM · Bug Report (Needs Information)
epriestley added a comment to T11515: `arc ade` should do something.

Also arc anist should probably be an alias for arc, so you can type arc anist diff.

Aug 23 2016, 3:59 AM · Feature Request
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).
uname -a
[ec2-user@ip-172-30-0-13 phabricator]$ uname -a
Linux ip-172-30-0-13 4.4.11-23.53.amzn1.x86_64 #1 SMP Wed Jun 1 22:22:50 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Aug 23 2016, 3:54 AM · Bug Report (Needs Information)
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

Thanks! I still can't reproduce this. Here's the install I brought up, following your instructions as closely as possible:

Aug 23 2016, 3:47 AM · Bug Report (Needs Information)
• javazyw added a comment to T11515: `arc ade` should do something.

I want to join in

Aug 23 2016, 3:38 AM · Feature Request
• ramprabhuj added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

@epriestley - Find the steps below. If the below seems insufficient, please close the ticket. I have a workaround which works and I have attempted to substitute any other extra reproduction steps with a diagnosis.

Aug 23 2016, 3:17 AM · Bug Report (Needs Information)
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

This is not a bug report until it has reproduction instructions. If we don't get reproduction instructions, we will not send this to the bottom of the list -- instead, we will close the report as "Invalid" and ignore the problem: we can not move forward without reproduction instructions.

Aug 23 2016, 1:00 AM · Bug Report (Needs Information)
• ramprabhuj added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

@epriestley - I want to be as clear as possible that this is NOT a support request. I have a perfectly working hack ( something I think actually addresses the root issue of JS dependencies at some level ). So I am just trying to help and I don't have a sense of how critical this issue is to the overall Phab roadmap. So I will perfectly happy with Phab eveb if this gets thrown at the bottom of the list and will be happy to stop updating this specific issue if its distracting.

Aug 23 2016, 12:49 AM · Bug Report (Needs Information)

Aug 22 2016

chad added a comment to T11515: `arc ade` should do something.

arc anoid already works

Aug 22 2016, 11:02 PM · Feature Request
jcarrillo7 added a comment to T11514: Authentication should have a way to customize the credentials name.

Ah yes I forgot about the fun of internationalization. Btw those fragments are correct 👍🏻 (I speak Spanish).

Aug 22 2016, 10:48 PM · Auth, LDAP, Feature Request
epriestley added a comment to T11514: Authentication should have a way to customize the credentials name.

Strings with sentence fragments like that can be difficult to translate in the normal human language sense, see:

Aug 22 2016, 10:34 PM · Auth, LDAP, Feature Request
yelirekim awarded T8236: `arc weld` should do something a 100 token.
Aug 22 2016, 10:21 PM · Contributor Onboarding, Arcanist
yelirekim created T11515: `arc ade` should do something.
Aug 22 2016, 10:21 PM · Feature Request
jcarrillo7 added a comment to T11514: Authentication should have a way to customize the credentials name.

The translation.override settings seems to be the easiest path forward. I definitely don't want to be modifying the source if I can help it.

Aug 22 2016, 10:15 PM · Auth, LDAP, Feature Request
epriestley added a comment to T11512: Add error handling to email commands.

It's possible there's some weirdness, but I think it just works. Let me know if that doesn't hold up in practice.

Aug 22 2016, 10:12 PM · Feature Request
yelirekim closed T11512: Add error handling to email commands as Invalid.

No I just read over all of the email commands and didn't see any exceptions thrown and I assumed this didn't work.

Aug 22 2016, 10:11 PM · Feature Request
epriestley edited this Badge.
Aug 22 2016, 10:10 PM
epriestley added a comment to T11514: Authentication should have a way to customize the credentials name.

This is probably something we'll need in the very long run for T6703 (if we legitimately let you connect to two different LDAP servers, it would be silly to have two "Login with LDAP" dialogs) but, yeah, using translation.override or just editing PhabricatorLDAPAuthProvider might be the shortest path today.

Aug 22 2016, 10:04 PM · Auth, LDAP, Feature Request
chad added a comment to T11514: Authentication should have a way to customize the credentials name.

Can you just override the translation? /config/edit/translation.override/

Aug 22 2016, 9:59 PM · Auth, LDAP, Feature Request
epriestley closed T9899: Chatbot requires access to the database as Resolved.

Per discussion T11508, I'm just going to officially call this a "feature".

Aug 22 2016, 9:46 PM · Phabot
jcarrillo7 added a comment to T11514: Authentication should have a way to customize the credentials name.

Essentially I would like to customize the "Login or register with LDAP" here to be "Login or register with OpenDirectory"

Login.png (808×1 px, 51 KB)

Aug 22 2016, 9:26 PM · Auth, LDAP, Feature Request
jcarrillo7 created T11514: Authentication should have a way to customize the credentials name.
Aug 22 2016, 9:24 PM · Auth, LDAP, Feature Request
epriestley added a comment to T8236: `arc weld` should do something.

(You are free to choose any other behavior -- even a useful one -- the requirement is only that arc weld do something.)

Aug 22 2016, 9:18 PM · Contributor Onboarding, Arcanist
epriestley moved T8236: `arc weld` should do something from Backlog to Intermediate on the Contributor Onboarding board.
Aug 22 2016, 9:18 PM · Contributor Onboarding, Arcanist
epriestley assigned T8236: `arc weld` should do something to jcox.

This will further familiarize you with arc. This may make sense to hold until some time after T5055, when arc workflows may change a bit. See also T11429.

Aug 22 2016, 9:17 PM · Contributor Onboarding, Arcanist
epriestley moved T11513: Convert the application selector in "pin applications" to a typeahead from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 9:11 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley assigned T11513: Convert the application selector in "pin applications" to a typeahead to jcox.

You can find this UI in Config → Home Page → Pin Application. Here's the relevant control:

Aug 22 2016, 9:11 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley added a comment to T11512: Add error handling to email commands.

I think you should be able to throw any exception to get a reply to the user. Here's what I expect you to get back (from T10709), at least roughly:

Aug 22 2016, 9:02 PM · Feature Request
epriestley added a project to T11513: Convert the application selector in "pin applications" to a typeahead: Contributor Onboarding.
Aug 22 2016, 9:01 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley moved T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:59 PM · Contributor Onboarding, Setup
epriestley moved T9117: Remove unused edges after Ponder comes out of beta from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:59 PM · Contributor Onboarding, Ponder
epriestley reassigned T9117: Remove unused edges after Ponder comes out of beta from chad to jcox.

This is similar to T9982. Complete that task first, which describes the SQL migration process in more detail.

Aug 22 2016, 8:59 PM · Contributor Onboarding, Ponder
epriestley renamed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from schemes upgrades problem, and can't use `git clone` to Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:54 PM · Contributor Onboarding, Setup
epriestley moved T8628: Modernize AphrontControllers to implement handleRequest from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:54 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley assigned T8628: Modernize AphrontControllers to implement handleRequest to jcox.

This is an opportunity to earn valuable contributor points and explore the dark corners of the codebase. Spooky!

Aug 22 2016, 8:54 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
avivey added a project to T11510: Expose build variables in harbormaster build plans to the execution environment: Harbormaster.
Aug 22 2016, 8:50 PM · Restricted Project, Harbormaster, Feature Request
sgielen added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

FWIW, in our case the bug was also triggered by logging in for the first time (for this account) using LDAP.

Aug 22 2016, 8:47 PM · Contributor Onboarding, Setup
epriestley reassigned T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from epriestley to jcox.

Welcome to PHP! This will familiarize you with PHP! PHP is a special language!

Aug 22 2016, 8:47 PM · Contributor Onboarding, Setup
epriestley merged T8253: Upload file fails, probably my fault into T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:41 PM · Contributor Onboarding, Setup
epriestley merged task T8253: Upload file fails, probably my fault into T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:41 PM · Files
epriestley added a comment to T8253: Upload file fails, probably my fault.

Guessing this is the same as T9235.

Aug 22 2016, 8:41 PM · Files
epriestley moved T9690: Remove calls to methods deprecated by newPage() from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:38 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley assigned T9690: Remove calls to methods deprecated by newPage() to jcox.

This will "help" you "become more familiar with Phabricator's codebase".

Aug 22 2016, 8:36 PM · Contributor Onboarding, Modernization, Infrastructure
avivey added a project to T11513: Convert the application selector in "pin applications" to a typeahead: User Delight.
Aug 22 2016, 8:31 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley moved T9692: Warn but continue when installing bot certificates with `arc install-certificate` from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:25 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley assigned T9692: Warn but continue when installing bot certificates with `arc install-certificate` to jcox.

This will sort of introduce you to modifying arc.

Aug 22 2016, 8:25 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley renamed T9692: Warn but continue when installing bot certificates with `arc install-certificate` from Install certificate for bot to Warn but continue when installing bot certificates with `arc install-certificate`.
Aug 22 2016, 8:12 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley moved T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:12 PM · Contributor Onboarding, Setup
epriestley assigned T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] to jcox.

Phabricator can be configured with a "preamble" script, for making certain environmental adjustments to deal with loadbalancers. This is described in Configuring a Preamble Script.

Aug 22 2016, 8:11 PM · Contributor Onboarding, Setup
epriestley moved T9900: Figlet does not properly render apostrophes with some characters from Backlog to Intermediate on the Contributor Onboarding board.
Aug 22 2016, 8:07 PM · Contributor Onboarding, Remarkup
epriestley assigned T9900: Figlet does not properly render apostrophes with some characters to jcox.

PhabricatorRemarkupFigletBlockInterpreter is a remarkup rule for rendering figlet fonts, invoked like this:

Aug 22 2016, 8:07 PM · Contributor Onboarding, Remarkup
epriestley moved T9982: Eventually, drop the conduit_connectionlog table from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:57 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley reassigned T9982: Eventually, drop the conduit_connectionlog table from epriestley to jcox.

Let's permanently destroy some data! This will introduce you to how to perform schema changes.

Aug 22 2016, 7:57 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley moved T10951: Search shows document types corresponding to disabled apps from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:50 PM · Contributor Onboarding, Search, Bug Report
epriestley added a comment to T10951: Search shows document types corresponding to disabled apps.

Perhaps in a separate change, it would be nice to maybe show the application name under the more modern document types -- for example, show "Diffusion" here:

Aug 22 2016, 7:49 PM · Contributor Onboarding, Search, Bug Report