Page MenuHomePhabricator

Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks
Closed, ResolvedPublic


When setting a limit with ->limit(X), it starts X futures initially, but falls back to doing one at a time for the rest of the futures. This is noticeable when running a linter or unit test engine that makes use of multiple futures as has a limit applied.

Event Timeline

hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: libphutil.
hach-que added a subscriber: hach-que.
eadler added a project: Restricted Project.Aug 5 2016, 5:23 PM

Re-reading D9115, I think I was never able to understand or reproduce this and it was ultimately mooted anyway.

Happy to look at this again if there's a modern repo / use case, but I don't think there's any way for this incarnation of it to move forward.