Page MenuHomePhabricator
Create Task
Maniphest T5042

Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks
Closed, ResolvedPublic
Actions

Description

When setting a limit with ->limit(X), it starts X futures initially, but falls back to doing one at a time for the rest of the futures. This is noticeable when running a linter or unit test engine that makes use of multiple futures as has a limit applied.

Revisions and Commits

rPHU libphutil
AbandonedD9115 Fix the Futures iterator so that it always tasks up to the limit

Related Objects

Event Timeline

hach-que created this task.May 14 2014, 2:36 AM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: libphutil.
hach-que added a subscriber: hach-que.
hach-que edited this Maniphest Task.May 14 2014, 7:37 AM
• nagym718 added a mock: Restricted Pholio Mock.Apr 7 2015, 8:03 AM
• nagym718 added a revision: D12308: Further improvements to array comma linter rule.
• nagym718 added a subtask: T7740: Chrome exhibits weird scrolling jumping with anchor in the URL.
• nagym718 added a subscriber: • nagym718.
• nagym718 removed a subscriber: • nagym718.
epriestley removed a subtask: T7740: Chrome exhibits weird scrolling jumping with anchor in the URL.Apr 7 2015, 12:25 PM
epriestley removed a revision: D12308: Further improvements to array comma linter rule.
epriestley removed a mock: Restricted Pholio Mock.
eadler added a project: Restricted Project.Aug 5 2016, 5:23 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 5:23 PM
epriestley closed this task as Resolved.Aug 24 2016, 12:00 AM

Re-reading D9115, I think I was never able to understand or reproduce this and it was ultimately mooted anyway.

Happy to look at this again if there's a modern repo / use case, but I don't think there's any way for this incarnation of it to move forward.

Phabricator · Built by Phacility