Page MenuHomePhabricator
Create Task
Maniphest T7286

Re-evaluate whether passing GET data in the body is a good idea
Closed, WontfixPublic
Actions

Description

It seems that we pass GET data in the body of the request for HTTPSFuture (and HTTPFuture). I'm not entirely sure that this is correct.

See P1725 and P1724.

Related Objects

Event Timeline

joshuaspence created this task.Feb 16 2015, 8:59 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: libphutil.
joshuaspence added a subscriber: joshuaspence.
joshuaspence claimed this task.Feb 28 2015, 12:10 PM
epriestley added a subscriber: epriestley.Mar 2 2015, 10:35 PM

Some guy who authored HTTP or something here suggests this is legal but non-useful:

https://groups.yahoo.com/neo/groups/rest-discuss/conversations/messages/9962

epriestley added a comment.Mar 2 2015, 10:35 PM

Although maybe that's talking about REST specifically. Unclear from context.

joshuaspence removed joshuaspence as the assignee of this task.May 18 2015, 12:02 AM

I haven't actually done anything on this.

epriestley closed this task as Wontfix.Aug 24 2016, 11:36 PM
epriestley claimed this task.

This doesn't seem to be doing anything bad in practice. I think you can put the data in the URI if you want too and it works fine. Not clear that this is wrong/invalid enough to completely prevent it, and hasn't moved forward in a year and a half or so.

Phabricator · Built by Phacility