Page MenuHomePhabricator
Create Task
Maniphest T8937

Unclear exception when patching non-existant revision
Closed, ResolvedPublic
Actions

Description

This exception gets thrown when I run arc patch <bad-rev-number>:

$ arc patch D4502
[2015-07-23 17:42:58] ERROR 2: Invalid argument supplied for foreach() at [/Users/abacker/src/phacility/arcanist/src/workflow/ArcanistWorkflow.php:1167]
arcanist(head=master, ref.master=5e4f9a2bf9d2), phutil(head=master, ref.master=aa6cd8f7e5e5)
  #0 ArcanistWorkflow::loadBundleFromConduit(ConduitClient, array) called at [<arcanist>/src/workflow/ArcanistWorkflow.php:1156]
  #1 ArcanistWorkflow::loadRevisionBundleFromConduit(ConduitClient, string) called at [<arcanist>/src/workflow/ArcanistPatchWorkflow.php:384]
  #2 ArcanistPatchWorkflow::run() called at [<arcanist>/src/workflow/ArcanistPatchWorkflow.php:397]
  #3 ArcanistPatchWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382]
Exception
Argument 1 passed to idx() must be of the type array, boolean given, called in /Users/abacker/src/phacility/arcanist/src/workflow/ArcanistWorkflow.php on line 1174 and defined
(Run with `--trace` for a full exception trace.)
49

Revisions and Commits

rARC Arcanist
D17325rARC224986af634e Provide a better error message when an invalid ID is given to arc patch

Related Objects

Event Timeline

staticshock created this task.Jul 23 2015, 5:46 PM
staticshock raised the priority of this task from to Needs Triage.
staticshock updated the task description. (Show Details)
staticshock added a project: Arcanist.
staticshock added a subscriber: staticshock.
epriestley added a subscriber: epriestley.Jul 23 2015, 8:18 PM

I spent 3 seconds on this, but the location where the error occurs and the locations where we know which error message to print are somewhat distant from one another so disentangling this will take a bit of work.

epriestley triaged this task as Low priority.Jul 23 2015, 8:19 PM
joshuaspence added a subscriber: joshuaspence.Jul 23 2015, 10:56 PM

I've seen this a bunch of times.

epriestley merged a task: T9317: Unclear exception when patching nonexistant revision.Sep 2 2015, 6:26 AM
chad renamed this task from Invalid argument supplied for foreach() to Unclear exception when patching non-existant revision.Jul 20 2016, 6:55 PM
chad merged a task: T11352: arc patch with invalid revision number fails with an exception.
chad added a subscriber: sascha-egerer.
epriestley moved this task from Backlog to arc patch on the Arcanist board.Aug 24 2016, 11:16 PM
epriestley merged a task: T11602: arc patch D1234 crashes with exception when D1234 does not exist.Sep 7 2016, 1:59 PM
epriestley added a subscriber: mna.
epriestley merged a task: T11671: Passing an incorrectly formatted revision ID to `arc patch` results in an exception.Sep 20 2016, 1:33 PM
epriestley added a subscriber: cspeckmim.
jcox added a subscriber: jcox.Feb 7 2017, 6:53 PM

Just spent some time tracking down what ended up being this issue. I wonder if adding a check in this block to query for the given revision would be sufficient enough to detect this case and return a more sensible error message. I can submit a diff for that if that'd be acceptable

cspeckmim added a comment.Feb 7 2017, 8:06 PM

Is it possible this is related to the E argument mentioned in T12071, but for arc clients?

joshuaspence added a comment.Feb 7 2017, 8:40 PM

I don't believe this is related to E being set in variables_order.

epriestley added a comment.Feb 7 2017, 9:00 PM

I'm going to fix this Real Soon, I absolutely Definitely Promise 100% ™ ®. But I'll accept a patch from a reputable contributor like @jcox any day.

jcox added a revision: D17325: Provide a better error message when an invalid ID is given to arc patch.Feb 8 2017, 2:02 PM
jcox closed this task as Resolved by committing rARC224986af634e: Provide a better error message when an invalid ID is given to arc patch.Feb 9 2017, 7:24 PM
jcox added a commit: rARC224986af634e: Provide a better error message when an invalid ID is given to arc patch.
Phabricator · Built by Phacility