D14382 fully deprecates many older ways of doing things. These aren't blocking anything, but should be modernized sooner or later. Specifically, these things are deprecated:
PhabricatorController->buildStandardPageResponse() (~15 callsites)
This is a very old method which was already effectively obsoleted by buildApplicationPage(). Callsites should be replaced with:
return $this->newPage() ->...
PhabricatorController->buildStandardPageView() (~12 callsites)
This is a very, very old method which was obsoleted by (or before?) buildApplicationPage(). Callsites should be replaced with:
return $this->newPage() ->...
PhabricatorController->buildApplicationPage() (~250 callsites)
This is the modern method which is now deprecated, although I don't expect us to get rid of it for a while. It should be replaced with:
return $this->newPage() ->...
*->buildSideNavView() (~175 callsites)
Almost all of these should probably be removed. The new code should have the same effect in most cases without requiring this method.
Some of these do extra stuff, and we'll need to make changes to accommodate that.
*->buildApplicationMenu() (~40 callsites)
Many of these can likely be simplified.
new PhabricatorApplicationSearchController() (~80 callsites)
All of these can almost certainly be simplified now.