Page MenuHomePhabricator

Improve functionality of rebasing commits with references in commit message
Closed, WontfixPublic

Description

In our (git) workflow, we commit changes to a feature branch which is sometimes rebased onto master in order to keep up with the latest changes. If we push this rebased branch, all commits with references such as 'closes TXXX' or 'ref TXXX' get new commit IDs and are treated as new commits by Phabricator.

As a result of this, some of our maniphest tasks have huge lists of related commits and people get lots of unnecessary notification emails.

To improve this situation, an option would be to ignore the commit ID and make Phabricator hash the changes/author/message/etcetera. I don't know if this is feasible or if other solutions are more efficient though.

Event Timeline

GMTA raised the priority of this task from to Needs Triage.
GMTA updated the task description. (Show Details)
GMTA updated the task description. (Show Details)
GMTA updated the task description. (Show Details)
GMTA added a subscriber: GMTA.
joshuaspence triaged this task as Wishlist priority.Jan 12 2015, 11:27 AM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

We haven't seen other requests in this vein, exactly, in about two years, and we generally don't expect users to rewrite published commits as a routine workflow.

You can set the "feature" branch to not autoclose to prevent this.

Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow may be somewhat relevant.