Page MenuHomePhabricator

Username autocompletion doesn't work with some non-US keyboard layouts
Open, Needs TriagePublic

Assigned To
None
Authored By
OCram
Feb 1 2016, 7:53 AM
Tags
Tokens
"Burninate" token, awarded by benwick."Baby Tequila" token, awarded by OCram.

Description

Situation

As mentioned in Autocompleting Usernames and Project Hashtags I tried to use this function with Google Chrome Browser but the autocompletion for users doesn't show up.

Testing Scenario

I tested with the following scenarios:

  • with latest Firefox and Google Chrome
  • against secure.phabcricator.com and own phabricator instance
  • All script and adblockers disabled.

Results

  • Username Autocompletion
FirefoxChrome
https.secure.phabricator.com
Personal Phabricator Instance
  • Projectname Autocompletion
FirefoxChrome
https.secure.phabricator.com
Personal Phabricator Instance

I see the ajax search queries for project autocompletion but not for any username actions.

  • project search query with chrome


  • username search query with Firefox (query missing with Chrome)


Event Timeline

OCram renamed this task from Username autocomplettion doesn't work wit Chrome Browser to Username autocomplettion doesn't work with Chrome Browser.Feb 1 2016, 7:53 AM
OCram created this task.

I can't reproduce this with Chrome 48.0.2564.97 on OSX. Here's the autocomplete working on my local instance in Chrome:

Here is is on this instance:

I will try it this evening on different client platforms and check whether it has something to do with our enterprise proxy or firewall.

  • Tested with Chrome 48.0.2564.97 on Windows7

Can't reproduce on any Windows nor any Chrome versions. (Win7, Win8, Win10), Chrome 48, 49.

@OCram, do you have an non-US keyboard?

In particular, do you type "@" by pressing "Shift + 2", or by typing some other combination of keys?

I tried it again with a fresh win10 install and the latest chrome version. Again no username autocompletion.

I'm working with a German keyboard layout (QWERTZ) where the @ is on Ctrl + Alt + Q or Alt Gr + Q.
Shift + 2brings me the " and doesn't work either :(

  • German standard keyboard layout:

Ah, thanks. I think this is almost certainly related to your keyboard layout and how we're detecting that you typed "@".

I can reproduce some variant of this locally by following these steps on OS X:

  • Switch keyboard input to German.
  • Insert an "@" by typing Option + L.
  • Autocomplete does not pop up.
epriestley renamed this task from Username autocomplettion doesn't work with Chrome Browser to Username autocomplettion doesn't work with some non-US keyboard layouts.Feb 1 2016, 5:34 PM
epriestley renamed this task from Username autocomplettion doesn't work with some non-US keyboard layouts to Username autocompletion doesn't work with some non-US keyboard layouts.

I do have similar problems with the keyboard shortcuts for displaying the Conpherence column (with "\") and the Darkconsole (using "`").

The shortcuts do not work if my MacOS keyboard is set to German, which is my usual configuration as I have a German keyboard. If I turn over to US keyboard the keys work as expected.

Can confirm, autocomplete for usernames does not work :-(

System: OS X (10.11)
Keyboard: German (Macbook, http://i.stack.imgur.com/K1nww.gif)
Insert "@": alt + L

Autocomplete for Projects works.

D16259 should fix the autocompleter on German layouts.

I think \ is a similar issue (you must press Alt to generate the keystroke) but the fix there should be a little more surgical.

The issue with ` is different: on German layouts, it acts as a combining character and does not generate a keypress event. The keydown event it generates does not identify it as a ` keypress.

eadler added a project: Restricted Project.Aug 5 2016, 5:05 PM

This happens for everyone here in the company on windows chrome with the HRV (Croatian) layout, where the @ symbol is achieved with the right side alt (ALTGR) + "V". Think that registers ALT + CTRL + V.

Ah, thanks! I think that should be relatively easy to fix.

fwiw, I can't reproduce this on OSX chrome any more. going to go test windows in german.... wish me glück.

It works great now with Windows + Chrome + German keyboard layout!