Page MenuHomePhabricator
Feed All Stories

Mar 5 2019

epriestley committed rP920ab13cfb86: Correct a possible fatal in the non-CSRF Duo MFA workflow (authored by epriestley).
Correct a possible fatal in the non-CSRF Duo MFA workflow
Mar 5 2019, 7:33 PM
epriestley closed D20234: Correct a possible fatal in the non-CSRF Duo MFA workflow.
Mar 5 2019, 7:33 PM
epriestley committed rPd192d04586ec: Make it more visually clear that you can click things in the "Big List of… (authored by epriestley).
Make it more visually clear that you can click things in the "Big List of…
Mar 5 2019, 7:32 PM
epriestley closed D20238: Make it more visually clear that you can click things in the "Big List of Clickable Things" UI element.
Mar 5 2019, 7:32 PM
epriestley committed rPee2bc07c9025: No-op old search indexing migrations which no longer run and have been… (authored by epriestley).
No-op old search indexing migrations which no longer run and have been…
Mar 5 2019, 7:32 PM
epriestley closed D20243: No-op old search indexing migrations which no longer run and have been obsoleted by upgrade "activities".
Mar 5 2019, 7:31 PM
epriestley committed rP34e90d8f5139: Clean up a few "%Q" stragglers in SVN repository browsing code (authored by epriestley).
Clean up a few "%Q" stragglers in SVN repository browsing code
Mar 5 2019, 7:31 PM
epriestley closed D20244: Clean up a few "%Q" stragglers in SVN repository browsing code.
Mar 5 2019, 7:31 PM
amckinley accepted D20224: Remove "Effective User" attachment from Repository Identities.
Mar 5 2019, 7:30 PM
epriestley committed rP9b0b50fbf469: Give "bin/worker" flags to repeat and retry tasks (authored by epriestley).
Give "bin/worker" flags to repeat and retry tasks
Mar 5 2019, 7:30 PM
epriestley closed D20246: Give "bin/worker" flags to repeat and retry tasks.
Mar 5 2019, 7:30 PM
amckinley accepted D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.

Just a bunch of language nitpicks.

Mar 5 2019, 7:29 PM
epriestley updated the diff for D20246: Give "bin/worker" flags to repeat and retry tasks.
  • Clarify help/guidance around "repeat" vs "retry" flags.
  • (Agreed on the ">>", I'll see about touching that up a little.)
Mar 5 2019, 7:25 PM
epriestley requested review of D20248: Make drag-and-drop on workboards interact with priority column headers.
Mar 5 2019, 7:15 PM
epriestley added a revision to T8135: drag & drop on a workboard sorted by priority behavior is surprising: D20248: Make drag-and-drop on workboards interact with priority column headers.
Mar 5 2019, 7:13 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a revision to T10333: Add groups to workboard columns: D20248: Make drag-and-drop on workboards interact with priority column headers.
Mar 5 2019, 7:13 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to D20246: Give "bin/worker" flags to repeat and retry tasks.

The execute workflow is always foreground, so execute --id ... --retry is now "foreground retry", and execute --id ... --retry --repeat is "foreground retry, repeating if necessary".

Mar 5 2019, 6:50 PM
amckinley accepted D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
Mar 5 2019, 6:41 PM
amckinley accepted D20234: Correct a possible fatal in the non-CSRF Duo MFA workflow.
Mar 5 2019, 6:37 PM
amckinley accepted D20246: Give "bin/worker" flags to repeat and retry tasks.
Mar 5 2019, 6:36 PM
amckinley accepted D20243: No-op old search indexing migrations which no longer run and have been obsoleted by upgrade "activities".
Mar 5 2019, 6:27 PM
amckinley accepted D20238: Make it more visually clear that you can click things in the "Big List of Clickable Things" UI element.
Mar 5 2019, 6:18 PM
amckinley accepted D20237: Recognize the official "Go" magic regexp for generated code as generated.
Mar 5 2019, 6:16 PM
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 5 2019, 5:57 PM · Plans
amckinley accepted D20244: Clean up a few "%Q" stragglers in SVN repository browsing code.
Mar 5 2019, 5:10 PM
epriestley added a comment to D20247: Add priority group headers to workboard columns (display only).

The new classes here are:

Mar 5 2019, 3:27 PM
epriestley requested review of D20247: Add priority group headers to workboard columns (display only).
Mar 5 2019, 3:23 PM
epriestley added a revision to T10333: Add groups to workboard columns: D20247: Add priority group headers to workboard columns (display only).
Mar 5 2019, 3:21 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley requested review of D20246: Give "bin/worker" flags to repeat and retry tasks.
Mar 5 2019, 1:37 AM
epriestley added a revision to T13253: Plans: Daemon Status Reporting: D20246: Give "bin/worker" flags to repeat and retry tasks.
Mar 5 2019, 1:36 AM · Plans, Daemons

Mar 4 2019

epriestley committed rPe15fff00a640: Use "LogLevel=ERROR" to try to improve "ssh" hostkey behavior without doing… (authored by epriestley).
Use "LogLevel=ERROR" to try to improve "ssh" hostkey behavior without doing…
Mar 4 2019, 5:38 PM
epriestley closed D20240: Use "LogLevel=ERROR" to try to improve "ssh" hostkey behavior without doing anything extreme/hacky.
Mar 4 2019, 5:38 PM
epriestley created E1697: Path of Exile: Synthesis.
Mar 4 2019, 3:43 PM

Mar 3 2019

amckinley accepted D20240: Use "LogLevel=ERROR" to try to improve "ssh" hostkey behavior without doing anything extreme/hacky.
Mar 3 2019, 11:34 PM

Mar 2 2019

epriestley requested review of D20245: When a user drags a card over a column, highlight the column border.
Mar 2 2019, 3:51 PM
epriestley added a revision to T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column": D20245: When a user drags a card over a column, highlight the column border.
Mar 2 2019, 3:49 PM · Workboards (v3)
epriestley added a comment to T10333: Add groups to workboard columns.

Technical stuff:

Mar 2 2019, 3:32 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley closed T13262: Dummy as Invalid.
Mar 2 2019, 3:18 PM
epriestley requested review of D20244: Clean up a few "%Q" stragglers in SVN repository browsing code.
Mar 2 2019, 2:18 PM
epriestley requested review of D20243: No-op old search indexing migrations which no longer run and have been obsoleted by upgrade "activities".
Mar 2 2019, 2:10 PM
epriestley added a comment to T13253: Plans: Daemon Status Reporting.

Some old migrations call PhabricatorSearchWorker::queueDocumentForIndexing(). This no longer works after D20200 because the PHP implementation expects a dateCreated column to exist, but it won't exist until 20190220.daemon_worker.completed.02.sql runs.

Mar 2 2019, 2:04 PM · Plans, Daemons

Mar 1 2019

epriestley requested review of D20242: When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits.
Mar 1 2019, 11:26 PM
epriestley added a revision to T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column": D20242: When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits.
Mar 1 2019, 11:24 PM · Workboards (v3)
epriestley added a comment to T10722: Communicate drag policies clearly in the workboard/list UIs.

Currently, if a card requires MFA to edit, we're unable to prompt the user. We likely should be able to do a prompt inline. This should also probably have a warning icon on the card itself.

Mar 1 2019, 10:46 PM · Workboards (v3), Bug Report
epriestley added a revision to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands: Unknown Object (Differential Revision).
Mar 1 2019, 5:53 PM · Phacility, Ops
epriestley requested review of D20240: Use "LogLevel=ERROR" to try to improve "ssh" hostkey behavior without doing anything extreme/hacky.
Mar 1 2019, 5:53 PM
epriestley added a revision to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands: D20240: Use "LogLevel=ERROR" to try to improve "ssh" hostkey behavior without doing anything extreme/hacky.
Mar 1 2019, 5:52 PM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

Another possible approach is to use -o LogLevel=ERROR. This gets us into trouble if there are useful INFO messages other than "permanently added X to list of known hosts", but presumably all the important stuff is rasied at ERROR or better.

Mar 1 2019, 5:43 PM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

For Drydock/Harbormaster, the only real way forward I see here is:

Mar 1 2019, 5:38 PM · Phacility, Ops
epriestley added a comment to T13261: Update upstream build steps to include timeouts and limits.

Currently, properties on upstream build steps are driven by CustomFields. T13248 briefly discusses a bit of context.

Mar 1 2019, 5:23 PM · Harbormaster
epriestley updated the task description for T13257: Plans: Unbeta New Harbormaster Log UI.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:19 PM · Plans, Harbormaster
epriestley triaged T13261: Update upstream build steps to include timeouts and limits as Normal priority.
Mar 1 2019, 5:19 PM · Harbormaster
epriestley added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

(This is likely to be very long, very rambling, and not particularly enlightening or useful.)

Mar 1 2019, 4:55 PM · Custom Fields, Maniphest
epriestley requested review of D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
Mar 1 2019, 3:56 PM
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
Mar 1 2019, 3:54 PM · Plans, Harbormaster
epriestley requested review of D20238: Make it more visually clear that you can click things in the "Big List of Clickable Things" UI element.
Mar 1 2019, 3:17 PM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20238: Make it more visually clear that you can click things in the "Big List of Clickable Things" UI element.
Mar 1 2019, 3:16 PM · Diffusion
epriestley requested review of D20237: Recognize the official "Go" magic regexp for generated code as generated.
Mar 1 2019, 3:00 PM
epriestley requested review of D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 1 2019, 2:14 PM
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 1 2019, 2:13 PM · Plans, Harbormaster
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

somewhat tricky to explain, and somewhat tricky to resolve

Mar 1 2019, 4:19 AM · Diffusion
epriestley committed rPHUf434f57578dd: When highlighting source, catch "python" for the PHP parser (authored by epriestley).
When highlighting source, catch "python" for the PHP parser
Mar 1 2019, 3:51 AM
epriestley closed D20231: When highlighting source, catch "python" for the PHP parser.
Mar 1 2019, 3:50 AM
epriestley committed rPbfe8f43f1a6f: Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters (authored by epriestley).
Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters
Mar 1 2019, 3:50 AM
epriestley closed T13260: Google auth fails and throws exception about missing client state parameter as Resolved by committing rPbfe8f43f1a6f: Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters.
Mar 1 2019, 3:50 AM · Auth
epriestley closed D20227: Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters.
Mar 1 2019, 3:50 AM
epriestley committed rP54006f481729: Stop "Mute Notifications" on Bulk Jobs from fataling (authored by epriestley).
Stop "Mute Notifications" on Bulk Jobs from fataling
Mar 1 2019, 3:50 AM
epriestley closed D20226: Stop "Mute Notifications" on Bulk Jobs from fataling.
Mar 1 2019, 3:50 AM
epriestley committed rP27ea775fda5f: Fix a log warning when searching for ranges on custom "Date" fields (authored by epriestley).
Fix a log warning when searching for ranges on custom "Date" fields
Mar 1 2019, 3:49 AM
epriestley closed D20225: Fix a log warning when searching for ranges on custom "Date" fields.
Mar 1 2019, 3:49 AM
epriestley requested review of D20235: Refine the "Mangled Webserver Response" setup check.
Mar 1 2019, 3:49 AM
epriestley committed rP75dfae10118a: Don't require any special capabilities to apply a "closed a subtask"… (authored by epriestley).
Don't require any special capabilities to apply a "closed a subtask"…
Mar 1 2019, 3:48 AM
epriestley closed D20223: Don't require any special capabilities to apply a "closed a subtask" transaction to a parent task.
Mar 1 2019, 3:48 AM
epriestley committed rP4cc556b576ab: Clean up a PhutilURI "alter()" callsite in Diffusion blame (authored by epriestley).
Clean up a PhutilURI "alter()" callsite in Diffusion blame
Mar 1 2019, 3:47 AM
epriestley closed D20222: Clean up a PhutilURI "alter()" callsite in Diffusion blame.
Mar 1 2019, 3:47 AM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20235: Refine the "Mangled Webserver Response" setup check.
Mar 1 2019, 3:47 AM · Diffusion
epriestley requested review of D20234: Correct a possible fatal in the non-CSRF Duo MFA workflow.
Mar 1 2019, 3:30 AM
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": D20234: Correct a possible fatal in the non-CSRF Duo MFA workflow.
Mar 1 2019, 3:28 AM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

From onsite:

Mar 1 2019, 2:53 AM · Diffusion
ysood added inline comments to D18960: Implement common infrastructure fields as export extensions.
Mar 1 2019, 1:33 AM
ysood added a comment to T5391: Support custom fields in 'Export to Excel'.

Resolved by D18959 + D18960. See also T13049.

Not all custom field types have export support today, but the infrastructure is in place and additional support is generally straightforward.

Mar 1 2019, 1:22 AM · Data Exporters
joshuaspence awarded D20221: Improve performance of "arc diff" updates for changes with large diff text a Burninate token.
Mar 1 2019, 1:00 AM
amckinley accepted D20223: Don't require any special capabilities to apply a "closed a subtask" transaction to a parent task.
Mar 1 2019, 12:20 AM
amckinley accepted D20226: Stop "Mute Notifications" on Bulk Jobs from fataling.
Mar 1 2019, 12:19 AM
amckinley accepted D20225: Fix a log warning when searching for ranges on custom "Date" fields.
Mar 1 2019, 12:19 AM
amckinley accepted D20222: Clean up a PhutilURI "alter()" callsite in Diffusion blame.
Mar 1 2019, 12:17 AM
amckinley accepted D20228: Expose Build Plan behaviors via "harbormaster.buildplan.search".
Mar 1 2019, 12:17 AM
amckinley accepted D20227: Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters.
Mar 1 2019, 12:16 AM
amckinley accepted D20231: When highlighting source, catch "python" for the PHP parser.
Mar 1 2019, 12:12 AM

Feb 28 2019

jbrownEP added a comment to D20225: Fix a log warning when searching for ranges on custom "Date" fields.

I cherry-picked this into our fork and it fixes the problem. ✅

Feb 28 2019, 11:58 PM
reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

and now when I re-run the command again, it gets another 7 commits and fails again. So, perhaps by me viewing the commit, I kick off a job that rebuilds something on the backend?

Feb 28 2019, 10:16 PM · Diffusion
reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

It's now failing on this one (consistently if I keep running it):

Feb 28 2019, 10:10 PM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Thanks. That looks like a perfectly normal object to me so I'm not sure what could cause it to fail to load.

Feb 28 2019, 9:31 PM · Diffusion
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

You will soon be able to give builds different "Hold Drafts" behaviors. See T13258.

Feb 28 2019, 9:29 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".
mysql> SELECT * FROM phabricator_repository.repository_commit WHERE id = 71471;
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
| id    | repositoryID | phid                           | commitIdentifier                         | epoch      | authorPHID | auditStatus | summary | importStatus | authorIdentityPHID | committerIdentityPHID |
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
| 71471 |           41 | PHID-CMIT-ohupojjoniypwpghvlr2 | 43034ccb9eac4ca8a655f655b726f73c5e551413 | 1438182566 | NULL       | none        |         |         1024 | NULL               | NULL                  |
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
1 row in set (0.01 sec)
Feb 28 2019, 9:28 PM · Diffusion
20after4 added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

Making a way to set fields to default: disabled would make this feature even better ;)

Feb 28 2019, 9:27 PM · Custom Fields, Maniphest
epriestley requested review of D20233: Implement Build Plan behavior "Affects Buildable".
Feb 28 2019, 9:26 PM
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20233: Implement Build Plan behavior "Affects Buildable".
Feb 28 2019, 9:24 PM · Plans, Harbormaster