Page MenuHomePhabricator
Differential D20222

Clean up a PhutilURI "alter()" callsite in Diffusion blame
ClosedPublic
Actions

Authored by epriestley on Feb 28 2019, 1:45 PM.

Details

Reviewers
amckinley
Commits
rP4cc556b576ab: Clean up a PhutilURI "alter()" callsite in Diffusion blame
Summary

See https://discourse.phabricator-community.org/t/exception-when-viewing-previous-revision-from-blame/2454/2.

Test Plan

Viewed blame, clicked "Skip Past This Commit". Got jumped to the right place instead of a URI exception.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 28 2019, 1:45 PM
epriestley requested review of this revision.Feb 28 2019, 1:47 PM
amckinley accepted this revision.Mar 1 2019, 12:17 AM
This revision is now accepted and ready to land.Mar 1 2019, 12:17 AM
Closed by commit rP4cc556b576ab: Clean up a PhutilURI "alter()" callsite in Diffusion blame (authored by epriestley). · Explain WhyMar 1 2019, 3:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48296

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility