Page MenuHomePhabricator

Stop "Mute Notifications" on Bulk Jobs from fataling
ClosedPublic

Authored by epriestley on Thu, Feb 28, 5:48 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-muting-completed-bulk-jobs/2449. Bulk Jobs have an "edge" table but currently do not support edge transactions. Add support.

This stops "Mute Notifications" from fataling.

The action probably doesn't do what the reporting user expects (it stops edits to the job object from sending notifications; it does not stop the edits the job performs from sending notifications) but I think this change puts us in a better place no matter what, even if we eventually clarify or remove this behavior.

Test Plan

Clicked "Mute Notifications" on a bulk job, got an effect instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Feb 28, 5:48 PM
epriestley requested review of this revision.Thu, Feb 28, 5:50 PM
amckinley accepted this revision.Fri, Mar 1, 12:19 AM
This revision is now accepted and ready to land.Fri, Mar 1, 12:19 AM
This revision was automatically updated to reflect the committed changes.