Page MenuHomePhabricator

Add a warning to revision timelines when changes land with ongoing or failed builds
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:54 PM.

Details

Summary

Ref T13258. The general idea here is "if arc land prompted you and you hit 'y', you get a warning about it on the timeline".

This is similar to the existing warning about landing revisions in the wrong state and hitting "y" to get through that. See D18808, previously.

These warnings make it easier to catch process issues at a glance, especially because the overall build status is now more complicated (and may legally include some failures on tests which are marked as unimportant).

The transaction stores which builds had problems, but I'm not doing anything to render that for now. I think you can usually figure it out from the UI already; if not, we could refine this.

Test Plan
  • Used bin/differential attach-commit to trigger extraction/attachment.
  • Attached a commit to a revision with various build states, and various build plan "Warn When Landing" flags.
  • Got sensible warnings and non-warnings based on "Warn When Landing" setting.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 1 2019, 3:54 PM
Owners added a subscriber: Restricted Owners Package.Mar 1 2019, 3:54 PM
epriestley requested review of this revision.Mar 1 2019, 3:56 PM
amckinley accepted this revision.Mar 5 2019, 6:41 PM
amckinley added inline comments.
src/applications/differential/engine/DifferentialDiffExtractionEngine.php
401

"convenient"

This revision is now accepted and ready to land.Mar 5 2019, 6:41 PM
epriestley updated this revision to Diff 48327.Mar 5 2019, 7:38 PM
  • Spelling.
This revision was automatically updated to reflect the committed changes.