Page MenuHomePhabricator
Differential D20237

Recognize the official "Go" magic regexp for generated code as generated
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:58 PM.
Tags
None
Referenced Files
F15531118: D20237.id48304.diff
Wed, Apr 23, 9:45 AM
F15525448: D20237.id48325.diff
Mon, Apr 21, 2:30 PM
F15518601: D20237.id.diff
Sat, Apr 19, 2:54 PM
F15514457: D20237.diff
Fri, Apr 18, 2:52 AM
F15431478: D20237.id.diff
Mar 24 2025, 12:33 PM
F15428485: D20237.diff
Mar 23 2025, 8:40 PM
F15424991: D20237.id48304.diff
Mar 23 2025, 1:37 AM
F15420486: D20237.id48325.diff
Mar 21 2025, 2:22 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated
Summary

See PHI1112. See T784. Although some more general/flexible solution is arriving eventually, adding this rule seems reasonable for now, since it's not a big deal if we remove it later to replace this with some fancier system.

Test Plan

Created a diff with the official Go generated marker, saw the changeset marked as generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
engine/
6 lines

Diff 48325

View Options

src/applications/differential/engine/DifferentialChangesetEngine.php

Loading...
Phabricator · Built by Phacility