Differential D20237

Recognize the official "Go" magic regexp for generated code as generated
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 8, 2:51 AM

	Unknown Object (File)
	Apr 16 2026, 6:50 AM

	Unknown Object (File)
	Mar 15 2026, 1:14 AM

	Unknown Object (File)
	Mar 14 2026, 2:01 AM

	Unknown Object (File)
	Jan 19 2026, 5:05 AM

	Unknown Object (File)
	Dec 2 2025, 12:28 PM

	Unknown Object (File)
	Nov 30 2025, 4:07 PM

	Unknown Object (File)
	Nov 29 2025, 2:25 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated

Summary

See PHI1112. See T784. Although some more general/flexible solution is arriving eventually, adding this rule seems reasonable for now, since it's not a big deal if we remove it later to replace this with some fancier system.

Test Plan

Created a diff with the official Go generated marker, saw the changeset marked as generated.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 1 2019, 2:58 PM

Harbormaster completed remote builds in B22165: Diff 48304.Mar 1 2019, 3:00 PM

epriestley requested review of this revision.Mar 1 2019, 3:00 PM

amckinley accepted this revision.Mar 5 2019, 6:16 PM

This revision is now accepted and ready to land.Mar 5 2019, 6:16 PM

Closed by commit rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated (authored by epriestley). · Explain WhyMar 5 2019, 7:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

engine/

DifferentialChangesetEngine.php

6 lines

Diff 48325

View Options

src/applications/differential/engine/DifferentialChangesetEngine.php

Recognize the official "Go" magic regexp for generated code as generatedClosedPublicActions