Page MenuHomePhabricator

Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters
ClosedPublic

Authored by epriestley on Feb 28 2019, 6:42 PM.
Tags
None
Referenced Files
F15530028: D20227.id48287.diff
Wed, Apr 23, 12:50 AM
F15521067: D20227.id48300.diff
Sun, Apr 20, 10:50 AM
F15518570: D20227.id.diff
Sat, Apr 19, 2:41 PM
F15516948: D20227.diff
Fri, Apr 18, 10:36 PM
F15418924: D20227.id48287.diff
Mar 21 2025, 2:26 AM
F15416609: D20227.id48300.diff
Mar 20 2025, 12:25 PM
F15413138: D20227.id.diff
Mar 19 2025, 5:08 PM
F15408688: D20227.diff
Mar 19 2025, 12:49 AM
Subscribers
None

Details

Summary

Fixes T13260. "QUERY_STRING" and "REQUEST_URI" are similar for our purposes here, but our nginx documentation tells you to pass "QUERY_STRING" and doesn't tell you to pass "REQUEST_URI". We also use "QUERY_STRING" in a couple of other places already, and already have a setup check for it.

Use "QUERY_STRING" instead of "REQUEST_URI".

Test Plan

Visited /oauth/google/?a=b, got redirected with parameters preserved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable