Page MenuHomePhabricator

Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters
ClosedPublic

Authored by epriestley on Feb 28 2019, 6:42 PM.
Tags
None
Referenced Files
F19567286: D20227.id48300.diff
Jan 31 2026, 9:16 PM
F19565838: D20227.id48300.diff
Jan 31 2026, 7:07 PM
F19548995: D20227.id48300.diff
Jan 27 2026, 1:35 AM
F19548994: D20227.id48300.diff
Jan 27 2026, 1:35 AM
F19153050: D20227.id48300.diff
Dec 11 2025, 7:07 AM
F19152896: D20227.id48300.diff
Dec 11 2025, 6:00 AM
F19082932: D20227.id48300.diff
Dec 2 2025, 12:27 PM
F18985053: D20227.id48287.diff
Nov 17 2025, 12:52 PM
Subscribers
None

Details

Summary

Fixes T13260. "QUERY_STRING" and "REQUEST_URI" are similar for our purposes here, but our nginx documentation tells you to pass "QUERY_STRING" and doesn't tell you to pass "REQUEST_URI". We also use "QUERY_STRING" in a couple of other places already, and already have a setup check for it.

Use "QUERY_STRING" instead of "REQUEST_URI".

Test Plan

Visited /oauth/google/?a=b, got redirected with parameters preserved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable