Page MenuHomePhabricator

Use "QUERY_STRING", not "REQUEST_URI", to parse raw request parameters
ClosedPublic

Authored by epriestley on Thu, Feb 28, 6:42 PM.

Details

Summary

Fixes T13260. "QUERY_STRING" and "REQUEST_URI" are similar for our purposes here, but our nginx documentation tells you to pass "QUERY_STRING" and doesn't tell you to pass "REQUEST_URI". We also use "QUERY_STRING" in a couple of other places already, and already have a setup check for it.

Use "QUERY_STRING" instead of "REQUEST_URI".

Test Plan

Visited /oauth/google/?a=b, got redirected with parameters preserved.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Feb 28, 6:42 PM
epriestley requested review of this revision.Thu, Feb 28, 6:44 PM
amckinley accepted this revision.Fri, Mar 1, 12:16 AM
This revision is now accepted and ready to land.Fri, Mar 1, 12:16 AM
This revision was automatically updated to reflect the committed changes.